Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary File not Uploading on a Form on 2.2.1 version #2121

Closed
DeanGonzalez opened this issue Feb 18, 2013 · 2 comments
Closed

Binary File not Uploading on a Form on 2.2.1 version #2121

DeanGonzalez opened this issue Feb 18, 2013 · 2 comments

Comments

@DeanGonzalez
Copy link

This is a follow up fix to this issue: #1977

To reproduce, create a new form with a text and binary field. Submit the form from front end of the site. Then re-edit the form content. The binary field has no file on it. File did not upload.

I did not see errors in the log, nothing helpful in firebug either.

Tested on 2.2.1 version

Interesting - seems to work in master but not in 2.2.1. Checked the file with the fixes and it is the same in both branches. Will have to debug and see what else changed in 2.2.1 to negate the fix. - Brent 2/19/2013

Seems that com.dotmarketing.cms.content.submit.util.SubmitContentUtil.java needs to be merged into 2.2.1 branch. I do not know what other things this would effect, but it would fix this issue. Specifically, this change is needed in 2.2.1 5955d11#src/com/dotmarketing/cms/content/submit/util/SubmitContentUtil.java - Brent 2/19/2013

@jtesser
Copy link
Contributor

jtesser commented Feb 19, 2013

Brent maybe this was a bad merge. This would the a higher priority then any 2.5 issues FWIW.

Make sure you branch from master-2.2.1 and make the pull request into that branch not master

brentgriffin pushed a commit that referenced this issue Feb 20, 2013
…s functionality to work in master but the changes from this file were not merged into master 2.2.1
dotjorgeu added a commit that referenced this issue Feb 20, 2013
fixes #2121 - this was a merge issue.  Changes to this file allows this ...
@DeanGonzalez
Copy link
Author

Tested on regular forms and submit content macro.... good upload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants