-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log viewer : highlight and filter #21848
Closed
Comments
|
alfredo-dotcms
added a commit
that referenced
this issue
Mar 28, 2022
nollymar
pushed a commit
that referenced
this issue
Mar 29, 2022
alfredo-dotcms
added a commit
that referenced
this issue
Mar 31, 2022
alfredo-dotcms
added a commit
that referenced
this issue
Mar 31, 2022
Noticed a 2 things here:
|
Internal QA: Needs work Now, the highlight disappears when I use the arrow keys: Screen.Recording.2022-06-13.at.11.08.56.AM.mov |
alfredo-dotcms
added a commit
that referenced
this issue
Jun 13, 2022
nollymar
pushed a commit
that referenced
this issue
Jun 13, 2022
3 tasks
Internal QA: Passed |
Fixed, tested on release-22.06 // Docker // FF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
When using the log viewer in dotCMS, customers often want to be able to filter the lines by a specific string. We should give people a "search" textbox that they can enter a string to highlight and a "filter" checkbox that that will filter any new messages for the presence of that string.
When a user enters a string to filter by, we find and replace matches of that string with highlighted version of it. The highlight should happen on keyup if the search String has a length of >=3. We will need to debounce onkeyup for like a second so we are not going crazy when a user is typing. Then, when a new message is printed, we should check for that string's presence and highlight that text as well.
If the user hits enter with a filter entered, we should hide the non-matching lines and only print new lines that match the filter.
The text was updated successfully, but these errors were encountered: