Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log viewer : highlight and filter #21848

Closed
wezell opened this issue Mar 14, 2022 · 16 comments · Fixed by #21911, #21933, #22275, #22341 or #22369
Closed

Log viewer : highlight and filter #21848

wezell opened this issue Mar 14, 2022 · 16 comments · Fixed by #21911, #21933, #22275, #22341 or #22369

Comments

@wezell
Copy link
Contributor

wezell commented Mar 14, 2022

When using the log viewer in dotCMS, customers often want to be able to filter the lines by a specific string. We should give people a "search" textbox that they can enter a string to highlight and a "filter" checkbox that that will filter any new messages for the presence of that string.

When a user enters a string to filter by, we find and replace matches of that string with highlighted version of it. The highlight should happen on keyup if the search String has a length of >=3. We will need to debounce onkeyup for like a second so we are not going crazy when a user is typing. Then, when a new message is printed, we should check for that string's presence and highlight that text as well.

If the user hits enter with a filter entered, we should hide the non-matching lines and only print new lines that match the filter.

@wezell wezell changed the title Highlight and filter log viewer Log viewer : highlight and filter Mar 14, 2022
@wezell
Copy link
Contributor Author

wezell commented Mar 22, 2022

  1. We need to execute the filter in the native jsp.
  2. Let's make the background black and the font white or off-white - like 225, 225, 225
  3. Resize the iframe window to fit its bounding box - full height.

@alfredo-dotcms
Copy link
Contributor

@alfredo-dotcms
Copy link
Contributor

nollymar pushed a commit that referenced this issue Mar 31, 2022
* #21848 Removed 'Update System Logging' button from log viewer - maintenance

* #21848 fix to keep filtered lines when new log lines are added
@nollymar nollymar linked a pull request Mar 31, 2022 that will close this issue
@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this May 19, 2022
@fabrizzio-dotCMS
Copy link
Contributor

Noticed a 2 things here:

  1. We don't have a filter checkbox to do this
    If the user checks the "filter" checkbox, we should hide the non-matching lines and only print new lines that match the filter. We're only doing the highlighting
  2. The filter is applied to strings of length greater than or equal to 2. It says it must be of length 3.

@alfredo-dotcms
Copy link
Contributor

@nollymar
Copy link
Contributor

Internal QA: Needs work

Now, the highlight disappears when I use the arrow keys:

Screen.Recording.2022-06-13.at.11.08.56.AM.mov

@alfredo-dotcms
Copy link
Contributor

@nollymar
Copy link
Contributor

Internal QA: Passed

@bryanboza
Copy link
Contributor

Fixed, tested on release-22.06 // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment