-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching empty containers in the Velocity2 cache when accessing in a language where the content doesn't exist #22534
Labels
OKR : Customer Support
Owned by Scott
QA : Approved
Release : 23.01.9
Included in LTS patch release 23.01.9
Release : 23.10.24
Bug-Fixing
Team : Lunik
Type : Defect
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
wezell
added a commit
that referenced
this issue
Sep 8, 2023
…g the site in, that the pages will be cached separately. ref: #22534
wezell
added a commit
that referenced
this issue
Sep 8, 2023
…g the site in, that the pages will be cached separately. ref: #22534
wezell
added a commit
that referenced
this issue
Sep 11, 2023
wezell
added a commit
that referenced
this issue
Sep 11, 2023
wezell
added a commit
that referenced
this issue
Sep 11, 2023
fmontes
pushed a commit
that referenced
this issue
Sep 14, 2023
#26036) * fix(velocity): this ensures that whatever language the user is viewing the site in, that the pages will be cached separately. ref: #22534 * fix(velocity): this ensures that whatever language the user is viewing the site in, that the pages will be cached separately. ref: #22534 * fix: invalid page cache #22534 * fix: invalid page cache #22534 * fix: invalid page cache #22534 * CR Feedback: Using Lazy objects for reading configuration properties. * Implementing SonarQube feedback. --------- Co-authored-by: Jose Castro <[email protected]>
INTERNAL QA: PASSEDAfter following the STR provided by @swicken-dotcms , this is what is happening after the code fix:
|
Approved: Tested on master_7713bff_SNAPSHOT, Docker, macOS 13.0, FF v113.0 |
erickgonzalez
added a commit
that referenced
this issue
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OKR : Customer Support
Owned by Scott
QA : Approved
Release : 23.01.9
Included in LTS patch release 23.01.9
Release : 23.10.24
Bug-Fixing
Team : Lunik
Type : Defect
Describe the bug
If you access a page in a language where the page and the content in the page both do not exist we are caching the empty container in the Velocity2 cache
Reproduced on: 21.06, 22.06
Related Ticket: https://dotcms.zendesk.com/agent/tickets/107703
To Reproduce
The environment must be configured with the defaults for the two following variables:
DEFAULT_CONTENT_TO_DEFAULT_LANGUAGE=false
DEFAULT_PAGE_TO_DEFAULT_LANGUAGE=true
NOTE: Do not add Spanish versions of either the page or the content
It appears we are caching the alternate language versions of content into the fallback default page containers in the Velocity2 cache
Expected behavior
When falling back we should not cache the content into the default language container
Additional context
This only occurs when we fall back the page and not the content. If the page exists in both languages but the content does not, it is cached correctly.
It als only occurs if the non-existent language is accessed before the default, otherwise the default language gets properly cached.
WORKAROUNDS
Create a version of the page in all languages
Set DEFAULT_CONTENT_TO_DEFAULT_LANGUAGE to true
The text was updated successfully, but these errors were encountered: