Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Logic for Showing Unread Announcements #25738

Closed
Tracked by #25733
damen-dotcms opened this issue Aug 8, 2023 · 6 comments · Fixed by #27377
Closed
Tracked by #25733

Build Logic for Showing Unread Announcements #25738

damen-dotcms opened this issue Aug 8, 2023 · 6 comments · Fixed by #27377
Labels
Merged OKR : Core Features Owned by Will OKR : Marketing Owned by Todd Priority : 3 Average QA : Approved QA : Passed Internal Release : 24.02.20 New binary field, AI plugin Team : Scout Type : New Functionality

Comments

@damen-dotcms
Copy link
Contributor

damen-dotcms commented Aug 8, 2023 •
edited
Loading

Parent Issue

#25733

Task

No response

Proposed Objective

Same as Parent Issue

Proposed Priority

Same as Parent Issue

Acceptance Criteria

Any time you close the Announcements Menu, that will clear all of the "Unread" messages.

Announcements Menu should close when you click off it, or click on any Announcement, or the "View All" button, or any links from the Announcement Menu.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@damen-dotcms damen-dotcms mentioned this issue Aug 8, 2023
Closed
@damen-dotcms damen-dotcms moved this from New to Current Sprint Backlog in dotCMS - Product Planning Aug 9, 2023
@nollymar nollymar moved this from Current Sprint Backlog to New in dotCMS - Product Planning Oct 9, 2023
@manuelrojas manuelrojas moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Oct 25, 2023
@manuelrojas manuelrojas moved this from Next 1-3 Sprints to New in dotCMS - Product Planning Oct 25, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Nov 7, 2023
@nollymar nollymar removed the stale label Nov 14, 2023
@erickgonzalez erickgonzalez removed the OKR : Customer Success Owned by Arno label Dec 19, 2023
@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Dec 21, 2023
@manuelrojas manuelrojas moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Jan 2, 2024
@manuelrojas manuelrojas self-assigned this Jan 2, 2024
@nollymar
Copy link
Contributor

nollymar commented Jan 8, 2024 •
edited by manuelrojas
Loading

We should include the utm info as part of the url as well.
It should be: ?utm_source=platform&utm_medium=XYZ.com&utm_campaign=announcement

for example: http://dotcms.com/?utm_source=platform&utm_medium={WEBSITEorCUSTOMERID}&utm_campaign=announcement

@nollymar nollymar mentioned this issue Jan 17, 2024
Closed
manuelrojas added a commit that referenced this issue Jan 18, 2024
@manuelrojas
#25738 Adding API integration
177a946
manuelrojas added a commit that referenced this issue Jan 18, 2024
@manuelrojas
#25738 Adding new @for
81f720e
manuelrojas added a commit that referenced this issue Jan 19, 2024
@manuelrojas
#25738 Adding styles
4489a02
manuelrojas added a commit that referenced this issue Jan 22, 2024
@manuelrojas
#25738 Adding link styling
30ab3b5
manuelrojas added a commit that referenced this issue Jan 22, 2024
@manuelrojas
#25738 Adding announcements validation
49d51b9
manuelrojas added a commit that referenced this issue Jan 22, 2024
@manuelrojas
#25738 Adding specs
458e1b3
manuelrojas added a commit that referenced this issue Jan 22, 2024
@manuelrojas
#25738 Right class name
ffa3220
manuelrojas added a commit that referenced this issue Jan 22, 2024
@manuelrojas
#25738 Fixing spec
22fe4bd
@manuelrojas manuelrojas moved this from In Progress to In Review in dotCMS - Product Planning Jan 22, 2024
@manuelrojas manuelrojas linked a pull request Jan 22, 2024 that will close this issue
#25738 Adding API integration #27377
Merged
3 tasks
manuelrojas added a commit that referenced this issue Jan 22, 2024
@manuelrojas
#25738 Adding small refactor
e88aa08
manuelrojas added a commit that referenced this issue Jan 24, 2024
@manuelrojas
#25738 Adding refactor
8312389
manuelrojas added a commit that referenced this issue Jan 24, 2024
@manuelrojas
#25738 PR Feedback
a7faddb
github-merge-queue bot pushed a commit that referenced this issue Jan 24, 2024
@manuelrojas
#25738 Adding API integration (#27377)
c17642a 
* #25738 Adding API integration

* #25738 Adding new @for

* #25738 Adding styles

* #25738 Adding link styling

* #25738 Adding announcements validation

* #25738 Adding specs

* #25738 Right class name

* #25738 Fixing spec

* PR Feedback

* #25738 Adding small refactor

* Fixing tests

* Delete core-web/libs/dotcms-webcomponents/src/components.d.ts

* web-components

* web-components

* #25738 Adding refactor

* Fix test

* #25738 PR Feedback
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Jan 24, 2024
@nollymar
Copy link
Contributor

nollymar commented Jan 25, 2024 •
edited
Loading

Note to QA: By default, announcements are pulled from dotcms.com. If you want to fetch announcements from your local environment, you need to set the property ANNOUNCEMENTS_BASE_URL to localhost, this way: ANNOUNCEMENTS_BASE_URL=http://localhost:8080/

Use this property FEATURE_FLAG_ANNOUNCEMENTS to turn on announcements menu

@nollymar nollymar reopened this Jan 25, 2024
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Jan 25, 2024
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jan 25, 2024
@dcolina dcolina assigned dcolina and unassigned dcolina Jan 29, 2024
@dcolina
Copy link
Contributor

dcolina commented Jan 29, 2024

Internal QA: Passed.

@dcolina dcolina moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jan 29, 2024
@nollymar
Copy link
Contributor

Additional PR: #27464

@github-project-automation github-project-automation bot moved this from QA - Backlog to Done in dotCMS - Product Planning Jan 29, 2024
@nollymar nollymar moved this from Done to QA - Backlog in dotCMS - Product Planning Jan 29, 2024
@bryanboza
Copy link
Contributor

Fixed, tested on master // Docker // FF

@bryanboza bryanboza added QA : Approved Release : 24.02.20 New binary field, AI plugin labels Jan 31, 2024
@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged OKR : Core Features Owned by Will OKR : Marketing Owned by Todd Priority : 3 Average QA : Approved QA : Passed Internal Release : 24.02.20 New binary field, AI plugin Team : Scout Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#25738 Adding API integration dotCMS/core
6 participants
@bryanboza @manuelrojas @erickgonzalez @nollymar @dcolina @damen-dotcms