Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a "super push" command to sync the files from to repo to the target dotcms env #25822

Closed
Tracked by #24354
nollymar opened this issue Aug 18, 2023 · 1 comment · Fixed by #26040
Closed
Tracked by #24354

Implement a "super push" command to sync the files from to repo to the target dotcms env #25822

nollymar opened this issue Aug 18, 2023 · 1 comment · Fixed by #26040
Labels
dotCMS : CLI Merged QA : Approved QA : Passed Internal Release : 24.01.26 Bug Fixing Team : Scout Type : Task

Comments

@nollymar
Copy link
Contributor

nollymar commented Aug 18, 2023 •
edited
Loading

Parent Issue

#24354

Having the input provided by #25821 , implement a CLI command that receives a list of files (or binaries) to be sync on a target dotCMS instance. This command should receive as well:

  • The target dotCMS env
  • dotCMS API Token, provided as a github secret

Expected result:
The target dotCMS instance should reflect all the changes made in the source GitHub repo, including destructive actions (folder, content type, file deletions). The command should provide feedback of the progress and execution. In case of error, provide the details.

Include tests accordingly.
@nollymar nollymar mentioned this issue Aug 18, 2023
Closed
@nollymar nollymar moved this from New to Current Sprint Backlog in dotCMS - Product Planning Aug 18, 2023
@nollymar nollymar mentioned this issue Aug 18, 2023
Closed
@nollymar nollymar moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Sep 6, 2023
jgambarios added a commit that referenced this issue Sep 7, 2023
@jgambarios
#25822 Refactor CLI push command for modularity and readability
91b6f2f 
Enhanced push command implementation by extracting push logic into specific subcommands and a shared mixin, improving modularity and readability of the code. Introduced PushMixin for common options and DotPush interface for specific push commands, and added a new FilesPushMixin for file push operations. This refactor aims to streamline the push process and make it easier to modify or extend in the future.
jgambarios added a commit that referenced this issue Sep 7, 2023
@jgambarios
#25822
e7a58ce
jgambarios added a commit that referenced this issue Sep 7, 2023
@jgambarios
#25822 Allow unmatched arguments when executing push sub commands
aabe1c9
jgambarios added a commit that referenced this issue Sep 7, 2023
@jgambarios
#25822 Enhanced push command by adding workspace validation
d98da81 
In this commit, the existing push command has been enhanced by including ability to validate workspace in the specified path. This includes checking if the provided file is a valid workspace using WorkspaceManager. If a valid workspace is not found, an IllegalArgumentException is thrown. In addition to this, a function to get the custom mixin associated with the push command is included with a default to return an empty optional.
jgambarios added a commit that referenced this issue Sep 8, 2023
@jgambarios
#25822 Adding tests
7346430
@jgambarios jgambarios linked a pull request Sep 11, 2023 that will close this issue
Issue 25822 implement a super push command #26040
Merged
@nollymar nollymar moved this from In Progress to In Review in dotCMS - Product Planning Sep 11, 2023
jgambarios added a commit that referenced this issue Sep 12, 2023
@jgambarios
#25822 Renaming variable
574a56b
nollymar pushed a commit that referenced this issue Sep 12, 2023
@jgambarios
feat(CLI): Implement a super push command (#26040)
c01f7cd 
Refs: #25822
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Sep 12, 2023
@nollymar nollymar reopened this Sep 12, 2023
@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Sep 12, 2023
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Sep 12, 2023
@github-project-automation github-project-automation bot moved this from Internal QA to Done in dotCMS - Product Planning Nov 13, 2023
@nollymar nollymar moved this from Done to Internal QA in dotCMS - Product Planning Nov 13, 2023
@nollymar nollymar moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Nov 17, 2023
@bryanboza
Copy link
Contributor

Fixed, tested on master // dotcms-cli-1.0.0-20231002.205953-1.jar

@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : CLI Merged QA : Approved QA : Passed Internal Release : 24.01.26 Bug Fixing Team : Scout Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 25822 implement a super push command dotCMS/core
3 participants
@jgambarios @bryanboza @nollymar