Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: Clean up dotcms-page.js #26820

Closed
Tracked by #26644
fmontes opened this issue Nov 28, 2023 · 0 comments · Fixed by #26824
Closed
Tracked by #26644

Edit EMA: Clean up dotcms-page.js #26820

fmontes opened this issue Nov 28, 2023 · 0 comments · Fixed by #26824
Assignees
@zJaaal
Labels
QA : Not Needed Team : Lunik Type : Task

Comments

@fmontes
Copy link
Member

fmontes commented Nov 28, 2023 •
edited
Loading

Parent Issue

#26644

Task

We need to reorganize this file because is growing too much, here is the proposal structure:

components/
├─ layout/
│  ├─ footer.js
│  ├─ header.js
│  ├─ navigation.js
├─ content-types/
│  ├─ banner.js
│  ├─ webPageContent.js
│  ├─ activity.js
│  ├─ product.js
│  ├─ image.js
lib/
├─ components/
│  ├─ row.js
│  ├─ container.js
│  ├─ contentlet.js
│  ├─ column.js
│  ├─ uibutton.js
├─ providers/
│  ├─ global.js

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

Acceptance Criteria

Extract components to external files

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@fmontes fmontes moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Nov 28, 2023
@zJaaal zJaaal self-assigned this Nov 28, 2023
@fmontes fmontes mentioned this issue Nov 28, 2023
Closed
@fmontes fmontes moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Nov 28, 2023
@zJaaal zJaaal linked a pull request Nov 28, 2023 that will close this issue
Fix #26820: NextJS EMA clean up #26824
Merged
fmontes pushed a commit that referenced this issue Nov 28, 2023
@zJaaal
chore(edit-ema): NextJS EMA clean up #26820
b6c4c98 
* dev (next js): basic clean up

* Update dotcms-page.js

* dev (next js): move utils to library
@github-project-automation github-project-automation bot moved this from In Progress to Done in dotCMS - Product Planning Nov 28, 2023
@KevinDavilaDotCMS KevinDavilaDotCMS mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
QA : Not Needed Team : Lunik Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #26820: NextJS EMA clean up dotCMS/core
3 participants
@fmontes @zJaaal @damen-dotcms