Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: Add Menu to Select Page Language #26821

Closed
Tracked by #26644
zJaaal opened this issue Nov 28, 2023 · 2 comments · Fixed by #26828
Closed
Tracked by #26644

Edit EMA: Add Menu to Select Page Language #26821

zJaaal opened this issue Nov 28, 2023 · 2 comments · Fixed by #26828
Assignees
@zJaaal
Labels
Team : Lunik Type : New Functionality

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Nov 28, 2023 •
edited
Loading

Parent Issue

#26644

User Story

As a Client I want to be able to change the language of my page, so I can edit the content for any language that I use to publish my content.

Acceptance Criteria

  • We should be able to see a button that opens a menu with the possible languages.
  • We should be able to select a language from that menu.
  • We should be able to see the language id on the query params of the page.
  • We should be able to see the proper page for the language we selected.

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
This was referenced Nov 28, 2023
Closed
Closed
@zJaaal zJaaal self-assigned this Nov 28, 2023
@zJaaal zJaaal moved this from New to In Progress in dotCMS - Product Planning Nov 28, 2023
@zJaaal zJaaal linked a pull request Nov 28, 2023 that will close this issue
Fix #26821: Edit EMA Add Language Selector #26828
Merged
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Nov 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Dec 4, 2023
fmontes pushed a commit that referenced this issue Dec 4, 2023
@zJaaal
feat(edit-ema): Add Language Selector #26821
1e7037f 
* dev (dot-ema): add language selector to toolbar

* dev (edit ema language selector): small styles tweaks

* Update edit-ema-toolbar.component.scss

* test (dot ema toolbar): add missing test cases

* dev (dot ema language selector): add iso to language

* dev (overlay panel): fix shadow

* fix format for languages that doesn't have country code

* dev (dot ema): refactor to change the approach of changing languages

* fix broken test

* dev (dot-ema): solve feedback

* dev (dot-ema): add const

* Update edit-ema-language-selector.component.ts

* dev (dot-ema): solve feedback

* dev (dot-ema): solve feedback
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Dec 4, 2023
@fmontes fmontes moved this from Internal QA to Done in dotCMS - Product Planning Dec 4, 2023
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Dec 4, 2023
@fmontes
Copy link
Member

fmontes commented Dec 5, 2023 •
edited
Loading

Needs work:

  1. Should close on select
  2. Should show selected option when get from URL
  3. Size is not right, use sm

We might consider using autocomplete here after all.

@fmontes fmontes moved this from Internal QA to In Progress in dotCMS - Product Planning Dec 5, 2023
@zJaaal
Copy link
Contributor Author

zJaaal commented Dec 6, 2023

We addressed those issues in this PR #26877 because we decided that Persona Selector and Language Selector should have the same look.

@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Dec 6, 2023
@zJaaal zJaaal moved this from In Review to Done in dotCMS - Product Planning Dec 8, 2023
@fmontes fmontes removed the Triage label Dec 12, 2023
@KevinDavilaDotCMS KevinDavilaDotCMS mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #26821: Edit EMA Add Language Selector dotCMS/core
2 participants
@fmontes @zJaaal