Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: Copy URL and API Link Buttons #26846

Closed
3 tasks done
Tracked by #26644
fmontes opened this issue Nov 29, 2023 · 0 comments · Fixed by #26905
Closed
3 tasks done
Tracked by #26644

Edit EMA: Copy URL and API Link Buttons #26846

fmontes opened this issue Nov 29, 2023 · 0 comments · Fixed by #26905
Assignees
@zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average Team : Lunik Type : New Functionality

Comments

@fmontes
Copy link
Member

fmontes commented Nov 29, 2023 •
edited by zJaaal
Loading

Parent

#26644

User Story

As a dotCMS user, I want to be able to quickly copy the URL of a page and have a quick link to the Page API response, so that I can quickly access and share the URLs.

Acceptance Criteria
Preview Give feedback
Figma.mp4

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.:

N/A

Assumptions & Initiation Needs

N/A

Quality Assurance Notes & Workarounds

N/A
@fmontes fmontes moved this from New to Current Sprint Backlog in dotCMS - Product Planning Nov 29, 2023
@fmontes fmontes changed the title Edit EMA: Quick Copy and Quick Link Feature Edit EMA: Copy URL and API Link Buttons Dec 5, 2023
@zJaaal zJaaal mentioned this issue Dec 6, 2023
Closed
@zJaaal zJaaal self-assigned this Dec 6, 2023
@zJaaal zJaaal moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Dec 6, 2023
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Dec 6, 2023
@zJaaal zJaaal linked a pull request Dec 6, 2023 that will close this issue
Fix #26846: Edit Ema copy url and api link buttons #26905
Merged
fmontes added a commit that referenced this issue Dec 11, 2023
@zJaaal @fmontes
feat(edit-ema): Add copy url and api link buttons (#26905) #26846
0b95007 
* dev (dot-ema): add language selector to toolbar

* dev (edit ema language selector): small styles tweaks

* Update edit-ema-toolbar.component.scss

* test (dot ema toolbar): add missing test cases

* dev (dot ema language selector): add iso to language

* dev (overlay panel): fix shadow

* fix format for languages that doesn't have country code

* dev (dot ema): refactor to change the approach of changing languages

* fix broken test

* dev (dot-ema): solve feedback

* dev (dot-ema): add const

* Update edit-ema-language-selector.component.ts

* dev (general): move dot avatar and use it in new persona selector

* dev (dot-ema): add basic flow for changing personas

* dev (dot-ema): add flow for persona change and save

* dev (dot-ema): get persona tag from nextJS

* just styling dummy buttons

* dev (dot-ema): Refactor to have a better handling in persona selection

* dev (persona selector): selected item is just used for autocomplete in multiple mode

* dev (persona-selector): add tests cases

* update mocked buttons

* Update core-web/libs/portlets/dot-ema/src/lib/components/edit-ema-persona-selector/edit-ema-persona-selector.component.spec.ts

Co-authored-by: Freddy Montes <[email protected]>

* Update core-web/libs/portlets/dot-ema/src/lib/components/edit-ema-persona-selector/edit-ema-persona-selector.component.spec.ts

Co-authored-by: Freddy Montes <[email protected]>

* Update core-web/libs/portlets/dot-ema/src/lib/components/edit-ema-persona-selector/edit-ema-persona-selector.component.spec.ts

Co-authored-by: Freddy Montes <[email protected]>

* Update core-web/libs/portlets/dot-ema/src/lib/components/edit-ema-persona-selector/edit-ema-persona-selector.component.ts

Co-authored-by: Freddy Montes <[email protected]>

* Update core-web/libs/portlets/dot-ema/src/lib/components/edit-ema-persona-selector/edit-ema-persona-selector.component.ts

Co-authored-by: Freddy Montes <[email protected]>

* Update core-web/libs/portlets/dot-ema/src/lib/services/dot-page-api.service.ts

Co-authored-by: Freddy Montes <[email protected]>

* solve feedback

* make vm$ null unless we have data to prevent bad requests

* solve feedback

* dev (persona selector): cleaning

* dev (persona selector): reset the value when rejecting

* remove todos from scoped PR

* Update toolbar styles and button size

* Update persona selector

* Imported necessary modules and fixed imports

* Update tests

* Fix tests

* Fix cd in listbox

* fix avatar bug on persona selector

* fix avatar bug on persona selector

* language selector now works as persona selector

* last cleanup

* dev (dot-ema): Add button to copy page url and to go to api response

* fix race condition on personalization

* solve feedback

---------

Co-authored-by: Freddy Montes <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Dec 11, 2023
@KevinDavilaDotCMS KevinDavilaDotCMS mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #26846: Edit Ema copy url and api link buttons dotCMS/core
2 participants
@fmontes @zJaaal