Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: Implement Bookmarks Button #26914

Closed
Tracked by #26644
zJaaal opened this issue Dec 7, 2023 · 0 comments · Fixed by #27158
Closed
Tracked by #26644

Edit EMA: Implement Bookmarks Button #26914

zJaaal opened this issue Dec 7, 2023 · 0 comments · Fixed by #27158
Assignees
@zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average Team : Lunik Type : New Functionality

Comments

@zJaaal
Copy link
Contributor

zJaaal commented Dec 7, 2023

Parent Issue

#26644

User Story

As a User I want to be able to Bookmark my pages, so I can browse then on Bookmarks panel from Pages Portlet.

Acceptance Criteria

  • User should be able to bookmark a page from Edit EMA
  • User should be able to delete a bookmark from Edit EMA
  • User should be able to edit the bookmark from Edit EMA
  • User should be able to see the new Bookmark in Bookmarks Panel from Pages Portlet

Proposed Objective

Please Select

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@zJaaal zJaaal self-assigned this Dec 7, 2023
@zJaaal zJaaal moved this from New to Current Sprint Backlog in dotCMS - Product Planning Dec 7, 2023
@fmontes fmontes removed the Triage label Dec 12, 2023
@zJaaal zJaaal mentioned this issue Dec 18, 2023
Closed
@zJaaal zJaaal moved this from Current Sprint Backlog to Next 1-3 Sprints in dotCMS - Product Planning Jan 2, 2024
@zJaaal zJaaal moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Jan 3, 2024
@zJaaal zJaaal linked a pull request Jan 3, 2024 that will close this issue
feat(edit-ema): #26914 Implement bookmarks button #27158
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 5, 2024
@zJaaal
feat(edit-ema): #26914 Implement bookmarks button (#27158)
d876966 
* chore(edit-ema): Move seo device selector

* feat(edit-ema): Add device selector to editor

* small refactor and add test cases

* Update dot-device-selector-seo.component.ts

* fix broken test

* solve feedback

* add ema device display component

* add flag to hide media tiles

* fix sonarqube

* Revert "fix sonarqube"

This reverts commit 01a881d.

* Update edit-ema-editor.component.ts

* fix sonarqube

* Update dot-device-selector-seo.component.ts

* Update dot-device-selector-seo.component.ts

* Update dot-device-selector-seo.component.ts

* typo

* Update dot-device-selector-seo.component.ts

* fix blue border bug

* fix sonarqube issue

* fix test

* address kevin feedback

* move create bookmark dialog

* fix favorite page test

* fix test

* fix sonarqube

* Update dot-message-display.service.ts

* fix experiments tests

* move favoriePageService

* add bookmarks save/delete workflow

* delete unused file

* fix broken tests

* =move edit-ema to new route

* =fix import

* =add nx lib for static imports

* =fix imports to avoid nx error

* =fix imports to avoid nx error

* fix imports

* delete not needed prettier

* prettier fix.

* fix tests

* Update package-lock.json

* fix error on tests

* refactor to use signals

* add test cases

* fix assets route

* fix styles for loading indicator

* Update dot-ema-bookmarks.component.ts
@github-project-automation github-project-automation bot moved this from In Progress to Done in dotCMS - Product Planning Jan 5, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(edit-ema): #26914 Implement bookmarks button dotCMS/core
2 participants
@fmontes @zJaaal