Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: Implement Page Tools for Reviewing Accessibility and Security #26998

Closed
1 task done
Tracked by #26644
fmontes opened this issue Dec 13, 2023 · 1 comment · Fixed by #27093 or #27127
Closed
1 task done
Tracked by #26644

Edit EMA: Implement Page Tools for Reviewing Accessibility and Security #26998

fmontes opened this issue Dec 13, 2023 · 1 comment · Fixed by #27093 or #27127
Assignees
@zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Not Needed Team : Lunik Type : New Functionality

Comments

@fmontes
Copy link
Member

fmontes commented Dec 13, 2023 •
edited by zJaaal
Loading

Parent

#26644

User Story

As a dotCMS user, I want to be able to use the page tools to review accessibility and security on the page, so I can ensure my pages are compliant with standards.

Acceptance Criteria
Preview Give feedback

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.:

image

Assumptions & Initiation Needs

  • All relevant components and dialogs are available.

Quality Assurance Notes & Workarounds

N/A

Sub-Tasks & Estimates:

N/A
@fmontes fmontes moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Dec 13, 2023
@fmontes fmontes mentioned this issue Dec 13, 2023
Closed
@zJaaal zJaaal self-assigned this Dec 21, 2023
@zJaaal zJaaal moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Dec 21, 2023
@zJaaal zJaaal linked a pull request Dec 21, 2023 that will close this issue
feat(edit-ema): Implement page tools for reviewing accessibility and security #26998 #27093
Merged
3 tasks
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Dec 21, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 21, 2023
@zJaaal
feat(edit-ema): Implement page tools for reviewing accessibility and …
6313130 
…security #26998 (#27093)

* dev (dot-ema): add flow for creating contentlets on the fly

* small fix on nextJS to avoid breaking the app

* dev (dot-ema): add test cases

* add placeholder for broken images in activity

* solve feedback

* refactor (dot-ema): Now we always have the language_id in queryParams for adding a contentlet

* dev (dot-ema): Add Nav Bar

* dev (dot-ema): Move editor to a component and make basic routing

* Update edit-ema-editor.component.ts

* Update dot-ema.component.spec.ts

* fix merge conflicts

* Update edit-ema-navigation-bar.component.scss

* small refactor for navigation bar

* dev (dot-ema): add wrapper components for portlets

* architecture clean up

* add lazy load

* unnest nav bar styles

* Update edit-ema-navigation-bar.component.html

* Update edit-ema-navigation-bar.component.scss

* Update edit-ema-navigation-bar.component.spec.ts

* Update edit-ema-navigation-bar.component.html

* refactor to use svg instead of base64 for experiments icon

* center svg properly

* general clean up

* Update edit-ema-navigation-bar.component.scss

* add template builder to edit-ema

* Update dot-ema.component.scss

* cleaning before refactor

* Update edit-ema-editor.component.ts

* fix tests

* fix broken tests

* clean up

* move dotRouter can deactivate route and dependencies to libs

* add flow to autosave and force saving on leave for template builder

* small tweaks to template builder

* map containers for Template Builder

* add containersMap and small clean up

* fix and add test cases

* delete repeat of code

* migrate tests to jest

* fix after merge and solve related feedback

* fix tests of store

* fix sonarqube

* solve feedback

* add routing to pages on siteSwitch

* Update dot-ema-shell.component.spec.ts

* add rules portlet to navigation

* clean up

* add seo tools to edit-ema

* sonarqube issue fixed

* solve feedback

* fix sonarqube

* Update edit-ema-navigation-bar.component.html

* Update edit-ema-navigation-bar.component.spec.ts
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Dec 21, 2023
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Dec 28, 2023
@fmontes
Copy link
Member Author

fmontes commented Dec 28, 2023

The first click doesn't work @zJaaal

@fmontes fmontes moved this from Internal QA to In Progress in dotCMS - Product Planning Dec 28, 2023
@zJaaal zJaaal mentioned this issue Dec 28, 2023
Merged
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Dec 28, 2023
@zJaaal zJaaal linked a pull request Dec 28, 2023 that will close this issue
chore(edit-ema) #26998 and #26997 IQA feedback #27127
Merged
@zJaaal zJaaal moved this from In Review to Internal QA in dotCMS - Product Planning Dec 28, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 28, 2023
@zJaaal
chore(edit-ema) #26998 and #26997 IQA feedback (#27127)
c7d448a 
* add despersonalize action

* Update edit-ema-editor.component.html

* Update edit-ema-editor.component.ts

* Fix padding for properties dialog

* refactor to make it work in all clicks

* Update dot-ema-shell.component.scss
@fmontes fmontes moved this from Internal QA to Done in dotCMS - Product Planning Jan 4, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS mentioned this issue Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Not Needed Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
2 participants
@fmontes @zJaaal