Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit EMA: Add and Trigger Workflow Actions #27159

Closed
3 tasks
Tracked by #26644
fmontes opened this issue Jan 3, 2024 · 5 comments · Fixed by #27336
Closed
3 tasks
Tracked by #26644

Edit EMA: Add and Trigger Workflow Actions #27159

fmontes opened this issue Jan 3, 2024 · 5 comments · Fixed by #27336

Comments

@fmontes
Copy link
Member

fmontes commented Jan 3, 2024

Parent

#26644

User Story

As a dotCMS user, I want to be able to trigger a workflow action from the editing page, so I can quickly take action on my content.

Tasks

Preview Give feedback
image

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

  • We use primeng's split button small.

Assumptions & Initiation Needs

Get Workflow Action

We have the DotWorkflowsActionsService responsible for retrieving the available action for content.

Endpoints:

  • Default Actions: /api/v1/workflow/initialactions/contenttype/${contentTypeId} [GET]
  • Actions By Inode: /api/v1/workflow/contentlet/${inode}/actions?renderMode=${'LISTING' || 'EDITING'} [GET]

Note: When you right-click on a Contentlet, LISTING displays the workflow actions. On the edit page, EDITING shows the workflow actions.

Execute/Run a Workflow Action

We have the DotWorkflowActionsFireService responsible of executing a workflow action in the system.

  • Fire Action: /api/v1/workflow/actions/${actionId}/fire?inode=${inode}&indexPolicy=WAIT_FOR [PUT]
  • BulkFire Action: /api/v1/workflow/contentlet/actions/bulk/fire [PUT]
  • Default Action: /api/v1/workflow/actions/default/fire/{defaultAction} [PUT]

For more information about the Workflow action endpoints, please refer to the documentation.

Quality Assurance Notes & Workarounds

N/A

Sub-Tasks & Estimates

  • Design split button
  • Add a split button to the toolbar
  • Read options from workflow actions endpoints
  • Trigger action with fire workflow action endpoint
@fmontes fmontes mentioned this issue Jan 3, 2024
@fmontes fmontes moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Jan 4, 2024
@fmontes fmontes moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Jan 4, 2024
@rjvelazco rjvelazco linked a pull request Jan 16, 2024 that will close this issue
@zJaaal zJaaal assigned zJaaal and rjvelazco and unassigned zJaaal Jan 16, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Jan 16, 2024
@zJaaal zJaaal moved this from In Progress to In Review in dotCMS - Product Planning Jan 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Jan 22, 2024
* dev: move DotWorkflowActions Component to UI library

* dev: move services to data-access library

* dev: fix tests

* dev: fix DotLocaleOptions interface

* dev: trigger Workflow Action

* dev: trigger workflow action and reload page if needed

* dev: show success and error message

* dev: cover tests v1

* dev: cover tests v2

* dev: cover tests v3

* dev: mock SplitButtonModule for test

* dev: fix test imports

* feedback v1

* dev: fix imports v2

* dev: feedback v2

---------

Co-authored-by: Freddy Montes <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Jan 22, 2024
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Jan 23, 2024
@rjvelazco rjvelazco linked a pull request Jan 24, 2024 that will close this issue
3 tasks
@KevinDavilaDotCMS
Copy link
Contributor

Passed Internal QA

Tested in master
Move:

Screen.Recording.2024-01-25.at.18.11.44.mov

Publish:

Screen.Recording.2024-01-25.at.18.13.06.mov

@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jan 25, 2024
@bryanboza
Copy link
Contributor

We need some work here when you execute the move action

Screen.Recording.2024-02-21.at.2.31.02.PM.mov

@bryanboza bryanboza moved this from QA - Backlog to QA - Rejected in dotCMS - Product Planning Feb 21, 2024
@rjvelazco
Copy link
Contributor

rjvelazco commented Feb 26, 2024

@bryanboza I was able to move the page. In the video, you are using a Web hosting service, it might be related to its configuration.

In addition, do we have any logs? Maybe vercel shows some logs too.

UPDATED: It looks like we need extra configuration in Vercel to be able to use EMA.

Video

iqa-issue-27159-edit-ema-add-and-trigger-workflow-actions.mov

Image

iqa-issue-27159-edit-ema-add-and-trigger-workflow-actions

@bryanboza bryanboza added Release: 24.03.11 Bug Fixing and removed Release : 24.03.1 Announcements labels Mar 1, 2024
@bryanboza bryanboza removed the Release: 24.03.11 Bug Fixing label Mar 12, 2024
@bryanboza bryanboza added the Release : 24.03.22 Bug Fixing label Mar 12, 2024
@fmontes
Copy link
Member Author

fmontes commented Mar 18, 2024

@bryanboza Updated here.

move-page.mp4

@fmontes fmontes moved this from QA - Rejected to QA - Backlog in dotCMS - Product Planning Mar 18, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Mar 19, 2024
@bryanboza bryanboza moved this from QA - In Progress to QA - Rejected in dotCMS - Product Planning Mar 19, 2024
@bryanboza bryanboza moved this from QA - Rejected to QA - Backlog in dotCMS - Product Planning Mar 21, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Mar 21, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on dotcms-qa-master.dotcms, Docker, macOS 13.0, FF v121.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment