-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Language.json should only contain isoCode #27448
Comments
…the language name and the ISO code. This update modifies the `ContentComparator` interface to include a `localFile` parameter in its findMatchingServerContent and localContains methods. Also, modifications have been made to all applicable classes that implement this interface, including support for file renaming if content changes. A NameUtil class has been added to generate standardized file names for Site, Language, and ContentType. Other enhancements include updating the push and pull handlers for Site, Language, and ContentType and improving their respective functionalities.
* #27448 Updating code to support in the language file descriptor only the language name and the ISO code. This update modifies the `ContentComparator` interface to include a `localFile` parameter in its findMatchingServerContent and localContains methods. Also, modifications have been made to all applicable classes that implement this interface, including support for file renaming if content changes. A NameUtil class has been added to generate standardized file names for Site, Language, and ContentType. Other enhancements include updating the push and pull handlers for Site, Language, and ContentType and improving their respective functionalities. * #27448 Improve cache clearing * #27448 Improvements in cache clearing * #27448 Rolling back unneeded change * #27448 Rolling back unneeded change * #27448 Removing the language label as can also be calculated from the ISO code * #27448 Renaming method * #27448 Fixed NPE * #27448 Handling ISO code as only available information in multiple commands * #27448 Javadoc * #27448 Updating IT * #27448 Renaming class --------- Co-authored-by: Nollymar Longa <[email protected]>
Internal QA: Passed Now, it is pretty easy to manipulate languages using only the iso code. |
Fixed, now the iso code is only the required parameter in the language.json file, we take this and generate all the other parameters based on that one.
It will generate:
Tested on master // Docker // FF |
On a pull, how is the The reason I'm wondering: If languages are being pushed between sites during a migration, is it possible they could end up being assigned different |
Parent Issue
No response
User Story
As a user, I want to be able to pull a language using a json file that only contains the isoCode and language name. For example:
The other fields should be excluded from the JSON file (it applies for push operations as well). Only language (name) and iso code should be considered.
{
"dotCMSObjectType" : "Language",
"id" : 4963328,"languageCode" : "es","countryCode" : "","language" : "Spanish","country" : "","defaultLanguage" : false,"isoCode" : "es"
}
Please modify the documentation and adjust the commands parameters accordingly
Acceptance Criteria
isoCode
anddotCMSObjectType
(internal use only).Proposed Objective
Core Features
Proposed Priority
Priority 3 - Average
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: