Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: 🧹 Move Edit Dialog to One Place #27526

Closed
4 tasks done
Tracked by #27546
fmontes opened this issue Feb 6, 2024 · 2 comments · Fixed by #27542
Closed
4 tasks done
Tracked by #27546

Edit EMA: 🧹 Move Edit Dialog to One Place #27526

fmontes opened this issue Feb 6, 2024 · 2 comments · Fixed by #27542
Assignees
@zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Not Needed Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Feb 6, 2024 •
edited by zJaaal
Loading

Parent

#26644

Task description

Currently, the edit dialog in dotCMS is scattered across multiple components, making it difficult to manage and maintain. The task is to move the edit dialog to one central location and implement its own state management.

Acceptance Criteria
Preview Give feedback

External Links

N/A

Assumptions & Initiation Needs

  • The existing edit dialog components must be thoroughly reviewed to identify all the components that need to be updated.
  • A comprehensive understanding of the current state management in edit ea=na is required to ensure a smooth transition to the new centralized location.

Quality Assurance Notes & Workarounds

  • Regression testing should be conducted to ensure that the move to the centralized edit dialog does not introduce any new bugs or issues.
  • Any existing workarounds or hacks related to the edit dialog should be documented and addressed during the move.
@zJaaal zJaaal self-assigned this Feb 6, 2024
@zJaaal zJaaal moved this from New to In Progress in dotCMS - Product Planning Feb 6, 2024
@zJaaal zJaaal linked a pull request Feb 7, 2024 that will close this issue
chore(edit ema): Move edit dialog to one place #27526 #27542
Merged
@fmontes fmontes mentioned this issue Feb 12, 2024
Open
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
@zJaaal
chore(edit ema): Move edit dialog to one place #27526 (#27542)
b3b629d 
* create dialog component and integrate in editor and shell

* Update dot-ema-dialog.component.spec.ts

* reset dialog when content is duplicated

* fix sonarq

* add tests for the store

* fix test in editor store

* add test cases

* fix broken tests

* fix sonarq

* solve feedback

* addressing feedback

* fix tests

* fix test

* added dialog status

* unify events of dialog

* add missing test case
@github-project-automation github-project-automation bot moved this from In Progress to Done in dotCMS - Product Planning Feb 12, 2024
@zJaaal zJaaal moved this from Done to Internal QA in dotCMS - Product Planning Feb 12, 2024
@zJaaal zJaaal reopened this Feb 12, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Feb 12, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Feb 15, 2024
@fmontes fmontes moved this from Internal QA to In Review in dotCMS - Product Planning Feb 16, 2024
@fmontes fmontes moved this from In Review to Internal QA in dotCMS - Product Planning Feb 16, 2024
@KevinDavilaDotCMS
Copy link
Contributor

Passed IQA

Tested in master
The behaviour of the dialog is the same as after refactor

Screen.Recording.2024-02-16.at.16.02.05.mov

@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Feb 16, 2024
@fmontes fmontes moved this from QA - Backlog to Done in dotCMS - Product Planning Feb 21, 2024
@fmontes
Copy link
Member Author

fmontes commented Feb 21, 2024

Moved to done because QA will be testing this in the full QA for headless.

@fmontes fmontes closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Not Needed Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(edit ema): Move edit dialog to one place #27526 dotCMS/core
3 participants
@fmontes @zJaaal @KevinDavilaDotCMS