Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Page V2: Allow User to Choose Content Editing for Individual or All Pages #27551

Closed
5 tasks done
Tracked by #27546
fmontes opened this issue Feb 8, 2024 · 11 comments · Fixed by #27582 or #28030
Closed
5 tasks done
Tracked by #27546

Edit Page V2: Allow User to Choose Content Editing for Individual or All Pages #27551

fmontes opened this issue Feb 8, 2024 · 11 comments · Fixed by #27582 or #28030
Assignees
@fmontes @rjvelazco
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 24.03.22 Bug Fixing Team : Lunik Team : Scout Type : New Functionality

Comments

@fmontes
Copy link
Member

fmontes commented Feb 8, 2024 •
edited by rjvelazco
Loading

Parent

#27546

User Story

As a content editor, I want to be informed if the content I am editing on a page will affect other pages, so that I can make an informed decision about whether to edit the content for all pages or only for the current page.

image

Acceptance Criteria
Preview Give feedback

Proposed Objective

Static content: "Core Features"

Proposed Priority

Static content: "Priority 3 - Average"

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Static content: "N/A"
@fmontes fmontes mentioned this issue Feb 8, 2024
Open
@rjvelazco rjvelazco self-assigned this Feb 8, 2024
@rjvelazco rjvelazco moved this from New to In Progress in dotCMS - Product Planning Feb 8, 2024
@fmontes fmontes changed the title Edit Page: Allow User to Choose Content Editing for Individual or All Pages Edit Page V2: Allow User to Choose Content Editing for Individual or All Pages Feb 8, 2024
@rjvelazco rjvelazco linked a pull request Feb 9, 2024 that will close this issue
feat(edit-page): Allow User to Choose Content Editing for Individual or All Pages #27551 #27582
Merged
@rjvelazco rjvelazco moved this from In Progress to In Review in dotCMS - Product Planning Feb 20, 2024
@rjvelazco
Copy link
Contributor

QA Team

This issue is waiting for this one: #27658

github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@rjvelazco
feat(edit-page): Allow User to Choose Content Editing for Individual …
2cad743 
…or All Pages #27551 (#27582)

* dev: move DotBinaryOptionSelector Component & DotCopyContentModal Service to ui lib

* feat(Edit EMA): allow user to copy content before editing

* test: update edit ema editor and utils tests

* refactor(copy content): move copy content logic to the

* fix: tests

* clean up

* dev: add variantId to mocks

* update tests

* feedback

* fix lint

* merge: resolve conflicts && get treeNode data

* fix: tests

* feat: add error handler

* chore: code cleanup

* feat: add loading dialog display for copy content

* chore: code cleanup

* test: update tests

* chore: code cleanup

* chore: code cleanup
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Feb 26, 2024
spbolton pushed a commit to spbolton/core that referenced this issue Feb 28, 2024
@rjvelazco @spbolton
feat(edit-page): Allow User to Choose Content Editing for Individual …
8993e5c 
…or All Pages dotCMS#27551 (dotCMS#27582)

* dev: move DotBinaryOptionSelector Component & DotCopyContentModal Service to ui lib

* feat(Edit EMA): allow user to copy content before editing

* test: update edit ema editor and utils tests

* refactor(copy content): move copy content logic to the

* fix: tests

* clean up

* dev: add variantId to mocks

* update tests

* feedback

* fix lint

* merge: resolve conflicts && get treeNode data

* fix: tests

* feat: add error handler

* chore: code cleanup

* feat: add loading dialog display for copy content

* chore: code cleanup

* test: update tests

* chore: code cleanup

* chore: code cleanup
@fmontes fmontes moved this from Done to Internal QA in dotCMS - Product Planning Feb 29, 2024
@fmontes fmontes self-assigned this Mar 1, 2024
@fmontes fmontes moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Mar 4, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Mar 12, 2024
@josemejias11
Copy link
Contributor

Failed: Tested on master_f3b48ba, Docker, macOS 13.0, FF v121.0.1

According with @rjvelazco the property needs to be restore with the use of the new sdk

@josemejias11 josemejias11 reopened this Mar 19, 2024
@github-project-automation github-project-automation bot moved this from QA - In Progress to Current Sprint Backlog in dotCMS - Product Planning Mar 19, 2024
@rjvelazco rjvelazco linked a pull request Mar 21, 2024 that will close this issue
chore(Edit Page V2): Bring back the "Allow User to Choose Content Editing for Individual or All Pages" feature #28030
Merged
@rjvelazco
Copy link
Contributor

@josemejias11 Fix: #28030

@github-project-automation github-project-automation bot moved this from Current Sprint Backlog to Done in dotCMS - Product Planning Mar 21, 2024
@josemejias11 josemejias11 moved this from Done to QA - Backlog in dotCMS - Product Planning Mar 21, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Mar 21, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on dotcms-qa-master.dotcms, Docker, macOS 13.0, FF v121.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Mar 25, 2024
@weiyiwang-dotcms
Copy link

Hi, I have a support case https://dotcms.zendesk.com/agent/tickets/115969 related to this. Customer is on v 24.04.05, and is using EMA. They are not receiving the popup when they click on the edit button, even though the content is on multiple pages.
screen-capture-edit-modal-popup-not-displayed.webm

@github-project-automation github-project-automation bot moved this from Done to Current Sprint Backlog in dotCMS - Product Planning Apr 16, 2024
@josemejias11
Copy link
Contributor

josemejias11 commented Apr 16, 2024 •
edited
Loading

Hi @weiyiwang-dotcms,

Currently this functionality is working properly on https://dotcms-qa-master.dotcms.site/c which is the environment where EMA was configured for testing.

Screenshot 2024-04-16 at 2 29 21 PM

@rjvelazco can you please check on this and confirm if is a version issue or something else. Thank you so much!

@rjvelazco
Copy link
Contributor

rjvelazco commented Apr 16, 2024 •
edited
Loading

It might be due to the SDK being out of synchrony. We had issues publishing the SDK on that version. Do we want to port it in release-24.04.05? Or can we update them to release-24.04.16? @weiyiwang-dotcms @fmontes @josemejias11

@fmontes fmontes closed this as completed Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Apr 18, 2024
@weiyiwang-dotcms
Copy link

Hi, the issue is still being reported by the customer. Here is a video that captures the issue.
screen-capture-modal-popup-still-not-displayed.webm

@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Apr 25, 2024
@bryanboza
Copy link
Contributor

I think here the problem reported by @weiyiwang-dotcms is in the old editor, this card is related to the new editor. Then we can close this one for now.

@weiyiwang-dotcms
Copy link

In what version of dotCMS does the new editor become available? Is the new editor available in release-24.04.16?

@rjvelazco
Copy link
Contributor

@nollymar Should we close this card and open a new one for the old editor to check the case @weiyiwang-dotcms reported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmontes fmontes

@rjvelazco rjvelazco

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 24.03.22 Bug Fixing Team : Lunik Team : Scout Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
5 participants
@fmontes @bryanboza @rjvelazco @josemejias11 @weiyiwang-dotcms