Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async nature to the dotAI actionlets #29381

Closed
Tracked by #29380
jdotcms opened this issue Jul 29, 2024 · 3 comments · Fixed by #29383
Closed
Tracked by #29380

Remove async nature to the dotAI actionlets #29381

jdotcms opened this issue Jul 29, 2024 · 3 comments · Fixed by #29383

Comments

@jdotcms
Copy link
Contributor

jdotcms commented Jul 29, 2024

Parent Issue

#29380

User Story

As an user, I want to be able to fire actions on batch without needing any async nature on the actionlets code

Acceptance Criteria

As part of the previews work, the IA Actionlets have been annotated to be ran in the UI only as batch, so we need to remove the async methods since it is not longer needed

Proposed Objective

Core Features

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@jdotcms jdotcms self-assigned this Jul 29, 2024
@jdotcms jdotcms mentioned this issue Jul 29, 2024
@jdotcms jdotcms moved this from New to In Progress in dotCMS - Product Planning Jul 29, 2024
jdotcms added a commit that referenced this issue Jul 29, 2024
@dsilvam dsilvam closed this as completed Aug 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 12, 2024
@jdotcms
Copy link
Contributor Author

jdotcms commented Aug 12, 2024

Note to QA:
since we have removed the async nature of the actionlets when you add the AI actionlet wont be visible on content editor, this means will be only able to be fired on batch/content search.
At the end the functionality is pretty much the same it was before, but not running on a separated thread by default.
Another important point, at the level the save+publish has been also removed from some of the AI actionlets, it means if you do not add the save actionlet after the AI actionlet, wont see any generation reflected.

@hmoreras hmoreras self-assigned this Aug 13, 2024
@hmoreras
Copy link
Contributor

hmoreras commented Aug 13, 2024

iQA notes findings:

  1. The AI token in the AI app, will work only in under the system host configuration, if is added in demo.dotcms.com wont work:
image
  1. If a workflow contains an IA sub actions the option Show When -> Editing is disabled. which is the expected behavior.
Screenshare.-.2024-08-13.5_04_51.PM.mp4
  1. The AI imagen generation workflow should only have the "AI Generate Image" in order to work correctly .
image

@hmoreras hmoreras moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Aug 14, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_600b4f3, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Aug 20, 2024
@dsilvam dsilvam changed the title Remove async nature to the IA actionlets Remove async nature to the dotAI actionlets Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants