Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UVE: Page content is deleted when change language #29572

Closed
KevinDavilaDotCMS opened this issue Aug 13, 2024 · 5 comments · Fixed by #29669, #29689 or #29905
Closed

UVE: Page content is deleted when change language #29572

KevinDavilaDotCMS opened this issue Aug 13, 2024 · 5 comments · Fixed by #29669, #29689 or #29905
Labels
Merged OKR : User Experience Owned by Jason Priority : 2 High QA : Approved QA : Passed Internal Release : 24.09.25 Bug Fixing Team : Scout Type : Defect

Comments

@KevinDavilaDotCMS
Copy link
Contributor

KevinDavilaDotCMS commented Aug 13, 2024 •
edited by zJaaal
Loading

Task

When we change the language we should see an empty page if we create a translation otherwise we should see the translated page.

VTL:

Screen.Recording.2024-08-13.at.3.38.10.PM.mov

Headless:

Screen.Recording.2024-08-13.at.4.41.46.PM.mov

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

Acceptance Criteria

We should be able to see the page when we change the language or translate if the page does not exist.
@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Aug 13, 2024
@zJaaal zJaaal changed the title UVE: Page contend is deleted when change language UVE: Page content is deleted when change language Aug 14, 2024
@nollymar nollymar moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Aug 14, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS mentioned this issue Aug 14, 2024
Closed
@rjvelazco rjvelazco mentioned this issue Aug 20, 2024
Merged
@rjvelazco rjvelazco linked a pull request Aug 20, 2024 that will close this issue
fix(Page Properties): keep custom template after update #29669
Merged
@rjvelazco rjvelazco moved this from In Progress to In Review in dotCMS - Product Planning Aug 20, 2024
@rjvelazco rjvelazco self-assigned this Aug 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2024
@rjvelazco
fix(Page Properties): keep custom template after update (#29669)
7ad6b2a 
### Proposed Changes
* fix(template): Page content is deleted after changing page properties
  - #29569
* fix(template): Page content is deleted when changing language
  - #29572
* fix(template): Keep custom template after update
  - #29034

## Videos

### Page content is deleted after changing page properties


https://github.com/user-attachments/assets/b1348572-89b9-404d-9df3-7cae19bd688a

### Page content is deleted when changing language


https://github.com/user-attachments/assets/4f3079da-77bf-4616-a031-7a3802c40d39

### Keep custom template after update


https://github.com/user-attachments/assets/23217700-1800-4ed7-ad7e-9ccc75fafac3
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 21, 2024
@rjvelazco rjvelazco removed their assignment Aug 21, 2024
@rjvelazco rjvelazco reopened this Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Aug 21, 2024
@rjvelazco rjvelazco self-assigned this Aug 21, 2024
@rjvelazco rjvelazco moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Aug 21, 2024
@rjvelazco rjvelazco linked a pull request Aug 21, 2024 that will close this issue
fix(UVE): Page content is deleted when changing language #29689
Merged
1 task
@rjvelazco rjvelazco moved this from In Progress to In Review in dotCMS - Product Planning Aug 21, 2024
@nollymar nollymar moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Sep 6, 2024
This was referenced Sep 10, 2024
Closed
Merged
@zJaaal zJaaal linked a pull request Sep 10, 2024 that will close this issue
fix(uve): Enhance UVE Dialog Handling and Reloads #29881 #29905
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2024
@zJaaal
fix(uve): Enhance UVE Dialog Handling and Reloads #29881 (#29905)
a5f4135 
### Proposed Changes
* Add properties to UVE Dialog Action to set `status` and
`isTranslation` values
* Fix double `loads` on navigate to maintain a healthy cycle between UVE
and Headless Client
* Fix Astro error where we cannot navigate
* Prevent Loading when `queryParams` did not changed
* Rename `load` method from the store to `init`
* Small fix on template builder that prevented UVE to start when
initializing the tool from layout
* Fix triple reload when Page Properties are saved

### Note 

This PR also fixes 

- #29572 QA Rejected
- #29836

### Screenshots




https://github.com/user-attachments/assets/140a8ae2-ab6d-48c4-a00a-7c6d96541802
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Sep 11, 2024
@zJaaal zJaaal removed their assignment Sep 11, 2024
@zJaaal zJaaal reopened this Sep 11, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Sep 11, 2024
@zJaaal zJaaal moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Sep 11, 2024
@dcolina dcolina self-assigned this Sep 16, 2024
@dcolina
Copy link
Contributor

dcolina commented Sep 17, 2024 •
edited
Loading

Internal QA: Passed.

The following use case is out of scope of the ticket, so it will be resolved in another card.

When creating a new version of a page in Spanish from an existing English page, and then attempting to swap back from the new Spanish version to the original English version, an unusual error message appears: "This URL does not exist (The page you are trying to access does not exist)." However, when re-entering the edit mode, the error does not reappear, indicating an inconsistent behavior in the flow.

Screen.Recording.2024-09-17.at.13.03.48.mov

@dcolina dcolina removed their assignment Sep 17, 2024
@dcolina dcolina moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Sep 17, 2024
@dcolina dcolina moved this from Current Sprint Backlog to QA - Backlog in dotCMS - Product Planning Sep 17, 2024
@dcolina dcolina closed this as completed Sep 17, 2024
@github-project-automation github-project-automation bot moved this from QA - Backlog to Internal QA in dotCMS - Product Planning Sep 17, 2024
@bryanboza bryanboza added Release : 24.09.25 Bug Fixing and removed Release : 24.09.21 UVE // Java21 labels Sep 20, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on ** trunk_4a9aadf**, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged OKR : User Experience Owned by Jason Priority : 2 High QA : Approved QA : Passed Internal Release : 24.09.25 Bug Fixing Team : Scout Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
8 participants
@bryanboza @nollymar @dcolina @zJaaal @rjvelazco @valentinogiardino @josemejias11 @KevinDavilaDotCMS