#12716 Update version_ts for all page versions. Refresh all page vers… #13076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions from cache.
wezell
reviewed
Nov 17, 2017
| private static void updateHTMLPageVersionTS(String id) throws DotDataException, DotSecurityException { | ||
| Identifier identifier = APILocator.getIdentifierAPI().find(id); | ||
| List<Contentlet> allContentletVersions = APILocator.getContentletAPI() | ||
| .findAllVersions(identifier, APILocator.getUserAPI().getSystemUser(), false); |
There was a problem hiding this comment.
This isn't the right method - this pulls all old versions of a piece of content which can be in the 100's . We need to pull a list of ContentletVersionInfos for a given piece of content
jdotcms
reviewed
Nov 17, 2017
| @Override | ||
| protected List<ContentletVersionInfo> findAllContentletVersionInfos(final String identifier)throws DotDataException, DotStateException { | ||
|
|
||
| HibernateUtil dh = new HibernateUtil(ContentletVersionInfo.class); |
There was a problem hiding this comment.
not sure but shouldn't include cache here? if not apply nvm my comment
| .findContentletByIdentifier(ident.getId(), false, languageId, APILocator.systemUser(), false); | ||
| IHTMLPage htmlPage = APILocator.getHTMLPageAssetAPI().fromContentlet(content); | ||
| PageServices.invalidateAll(htmlPage); | ||
| List<Contentlet> cons = APILocator.getContentletAPIImpl().findContentlets(Lists.newArrayList(inodes)); |
There was a problem hiding this comment.
rename it to contenlets or contentList
jdotcms
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions from cache.