Issue 11609 fixes #13238

jdotcms · 2017-12-19T18:06:30Z

No description provided.

…ate table and other minor changes.

…the scheme

…ctions, etc

…, unlocked and both choices

…hemes

CLAassistant · 2017-12-19T18:06:37Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ oswaldogallango
✅ jcastro-dotcms
❌ Jonathan

Jonathan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

dev-dotcms · 2017-12-19T18:11:22Z

dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowFactoryImpl.java

 import com.dotmarketing.util.InodeUtils;
 import com.dotmarketing.util.Logger;
 import com.dotmarketing.util.UUIDGenerator;
 import com.dotmarketing.util.UtilMethods;
+import com.google.common.collect.ImmutableList;
 import com.liferay.portal.model.User;
 import com.liferay.util.StringPool;


Remove this unused import 'com.liferay.util.StringPool'.

dev-dotcms · 2017-12-19T18:11:23Z

SonarQube analysis reported 3 issues

1 critical
2 minor

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

WorkflowFactoryImpl.java#L568: Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
WorkflowSQL.java#L84: Rename this field "DELETE_CONTENTLET_STEPS" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

jgambarios · 2018-01-08T19:26:58Z

Closed as dup of #13216

jcastro-dotcms and others added 30 commits November 6, 2017 09:41

#11609 : Updating DB scripts. Adding upgrade task to create intermedi…

9525217

…ate table and other minor changes.

#11609 added first draft for add/edit workflow action

f285dc8

#11609 merge done

8a6444a

#11609 almost code done for save/edit workflow actions associated to …

ce25b42

…the scheme

#11609 the add action and action to step are done

60ef0e7

#11609 Added the delete steps and dependencies/minor fixes for transa…

eeb4172

…ctions, etc

#11609 delete action from step done in the ui/ajax and endpoint

0929145

#11609 Added the deletes for the UI

1f17c62

#12960 changes for reorder done

4cd30de

#13104 Added the new field requires lock options that supports locked…

fe70d6c

…, unlocked and both choices

#12960 added the scripts changes for all dbs

677079c

#12960 MERGE MASTER DONE

161c206

#12960 added changes for the workflow, action and step new relationships

ab38919

#12960 merge done

d30507c

#12960 notes and fixes

4992dd9

#12960 fixing the IT test

df465db

#12960 code review feedback

f558a7b

#11691 added changes for the new endpoint for getting content type sc…

329da3e

…hemes

#12960 added changes for h2 and mysql

a0fbd9c

#12960 added the changes for the show_on column

82e3837

#12960 adding changes for the showOn

96c6ceb

#12960 merge done

6a709f4

#12960 changes for show on functionality

c4d12df

resolving the error of the missing schemeid

92347c1

solving issue with content resource test

5ab4a08

Fixing the Task04305UpdateWorkflowActionTable

694375b

Reverting to master configuration

62e4317

#12960 merge done

6caba12

#12960 fixing postgres and oracle UT

43483c8

#11609 fixes for 11609

cc1cde1

Jonathan added 3 commits December 14, 2017 10:41

#11609 merge done

8f0b9bf

#11609 configuration rollback

0261f20

#11609 fixes by code review

ff87ab2

dev-dotcms reviewed Dec 19, 2017

View reviewed changes

jgambarios closed this Jan 8, 2018

jgambarios deleted the issue-11609-fixes branch January 8, 2018 19:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 11609 fixes #13238

Issue 11609 fixes #13238

jdotcms commented Dec 19, 2017

CLAassistant commented Dec 19, 2017 •

edited

Loading

dev-dotcms Dec 19, 2017

dev-dotcms commented Dec 19, 2017

jgambarios commented Jan 8, 2018

Issue 11609 fixes #13238

Issue 11609 fixes #13238

Conversation

jdotcms commented Dec 19, 2017

CLAassistant commented Dec 19, 2017 • edited Loading

dev-dotcms Dec 19, 2017

Choose a reason for hiding this comment

dev-dotcms commented Dec 19, 2017

2 extra issues

jgambarios commented Jan 8, 2018

CLAassistant commented Dec 19, 2017 •

edited

Loading