Issue 13309 webdav multiple files unique constraint #13347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdotcms
reviewed
Jan 8, 2018
| @@ -2310,6 +2318,58 @@ private void deleteInsertPermission(Permissionable permissionable, String type, | |||
| } | |||
| } | |||
|
|
|||
| // Method to Insert a new Permission Reference, or if it exists, it will udpate it | |||
| private void upsertPermission(DotConnect dc1, String permissionId, Permissionable newReference, String type) throws DotDataException { | |||
| if (DbConnectionFactory.isH2()) { | |||
There was a problem hiding this comment.
Same principle of a command to generate the sql based on the current db type, see below comment
jdotcms
reviewed
Jan 8, 2018
|
|
||
| //Update Parameters: Generate column = value pairs, used for the Update part | ||
| StringBuffer buffer = new StringBuffer(); | ||
| for (int i = 0; i < columns.length; i++) { |
There was a problem hiding this comment.
Why not to change this for a command pattern, such as
interface UpsertCommand command = this.getUpsertCommand(dbType);
query = command.execute (table, StringUtil.merge(columns),
conditionalColumn,
StringUtil.merge(values));
dsilvam
approved these changes
Jan 11, 2018
dsilvam
deleted the
issue-13309-Webdav-Multiple-Files-Unique-Constraint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.