Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folderapitest rename logging #13491

Merged
merged 3 commits into from
Jan 23, 2018
Merged

Folderapitest rename logging #13491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df0743
Include more logging for FolderAPITest.delete
dsilvam Jan 23, 2018
85d8f2d
more logging.
dsilvam Jan 23, 2018
8ec34c7
merge with master.
dsilvam Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...S/src/integration-test/java/com/dotmarketing/portlets/folders/business/FolderAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ public void renameFolder() throws Exception {

// make sure the rename is properly propagated on children (that's done in a db trigger)
Logger.info(this, "ftest.getInode:" + ftest.getInode());
Logger.info(this, "identifier from cache: " + CacheLocator.getIdentifierCache().getIdentifier( ftest.getInode()));
Logger.info(this, "identifier from cache: " + identifierAPI.loadFromCache( ftest.getInode()));
Logger.info(this, "identifier from db: " + identifierAPI.loadFromDb( ftest.getInode()));
Logger.info(this, "identifier from db's asset name: " + identifierAPI.loadFromDb( ftest.getInode()).getAssetName());

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change!

final Identifier ident = identifierAPI.find(ftest);
final Identifier ident1 = identifierAPI.find(ftest1);
final Identifier ident2 = identifierAPI.find(ftest2);
Expand Down
2 changes: 1 addition & 1 deletion dotCMS/src/main/java/com/dotmarketing/business/IdentifierCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public abstract class IdentifierCache implements Cachable {

abstract protected void addIdentifierToCache(String identifier, String inode) ;

abstract public Identifier getIdentifier(String identId);
abstract protected Identifier getIdentifier(String identId);

abstract protected Identifier getIdentifier(Host host, String URI);

Expand Down
2 changes: 1 addition & 1 deletion dotCMS/src/main/java/com/dotmarketing/business/IdentifierCacheImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ protected Identifier getIdentifier( String hostId, String URI ) {
}


public Identifier getIdentifier(String identId) {
protected Identifier getIdentifier(String identId) {

Identifier value = null;
try {
Expand Down