Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22007 fixes rewrites when its a urlmap #22142

Merged
merged 4 commits into from
May 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@
import static com.dotmarketing.portlets.rules.parameter.comparison.Comparison.IS_NOT;
import static com.dotmarketing.portlets.rules.parameter.comparison.Comparison.REGEX;
import static com.dotmarketing.portlets.rules.parameter.comparison.Comparison.STARTS_WITH;

import com.dotcms.util.HttpRequestDataUtil;
import java.util.Map;
import java.util.regex.Pattern;
import javax.servlet.RequestDispatcher;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import com.dotmarketing.filters.CMSFilter;
import com.dotmarketing.filters.CMSUrlUtil;
import com.dotmarketing.filters.Constants;
import com.dotmarketing.portlets.rules.RuleComponentInstance;
import com.dotmarketing.portlets.rules.exception.ComparisonNotPresentException;
import com.dotmarketing.portlets.rules.exception.ComparisonNotSupportedException;
Expand All @@ -21,14 +23,6 @@
import com.dotmarketing.portlets.rules.parameter.comparison.RegexComparison;
import com.dotmarketing.portlets.rules.parameter.display.TextInput;
import com.dotmarketing.portlets.rules.parameter.type.TextType;
import com.dotmarketing.util.Logger;
import com.dotmarketing.util.UtilMethods;
import com.dotmarketing.util.WebKeys;
import java.io.UnsupportedEncodingException;
import java.util.Map;
import java.util.regex.Pattern;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

/**
* This conditionlet will allow CMS users to check the current URL in a request.
Expand Down Expand Up @@ -62,29 +56,52 @@ public VisitorsCurrentUrlConditionlet() {

@Override
public boolean evaluate(HttpServletRequest request, HttpServletResponse response, Instance instance) {
String requestUri = CMSUrlUtil.getInstance().getURIFromRequest(request);


String[] requestUri = getURIsFromRequest(request);

String index = CMSFilter.CMS_INDEX_PAGE;
String pattern = processUrl(instance.patternUrl,index, instance);

return evaluate(request, instance, requestUri, pattern);
}

public boolean evaluate(HttpServletRequest request, Instance instance, String requestUri, String pattern) {

if( instance.comparison.perform(requestUri, pattern)) {
if(instance.comparison.getId().equals(REGEX.getId())){
Pattern regex= RegexComparison.patternsCache.get(pattern, k-> Pattern.compile(k));
request.setAttribute(CURRENT_URL_CONDITIONLET_MATCHER, regex);
}

return true;
}
return false;
}
public boolean evaluate(HttpServletRequest request, Instance instance, String[] requestUris, String pattern) {

for (String requestUri : requestUris) {
if (instance.comparison.perform(requestUri, pattern)) {
if (instance.comparison.getId().equals(REGEX.getId())) {
Pattern regex = RegexComparison.patternsCache.get(pattern, k -> Pattern.compile(k));
request.setAttribute(CURRENT_URL_CONDITIONLET_MATCHER, regex);
}
return true;
}
}
return false;
}


/**
* Get the requestURI from the urlmap and/or vanity url. If the request has been forwarded, both the
* origial URI (urlmap) and the new uri (detail page) will be evaluated.
*
* @param request
* @return
*/
private String[] getURIsFromRequest(HttpServletRequest request) {
final String cmsURI = CMSUrlUtil.getInstance().getURIFromRequest(request);
final String forwardedFor = (String) request.getAttribute(RequestDispatcher.FORWARD_REQUEST_URI);
return (forwardedFor == null)
? new String[] {
cmsURI}
: new String[] {
forwardedFor,
cmsURI};

}





/**
* Process the baseUrl to comply with:
* <ul><li>Does not include query params</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public void testComparisons(TestCase aCase) throws Exception {
}

private boolean runCase(TestCase aCase) {
return aCase.conditionlet.evaluate(aCase.request, aCase.conditionlet.instanceFrom(aCase.params), aCase.uri,aCase.pattern);
return aCase.conditionlet.evaluate(aCase.request, aCase.conditionlet.instanceFrom(aCase.params), new String[] {aCase.uri},aCase.pattern);
}

@Test(expected = IllegalStateException.class)
Expand Down