Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21619 Changes on Config class #22209

Merged
merged 4 commits into from
May 13, 2022
Merged

#21619 Changes on Config class #22209

merged 4 commits into from
May 13, 2022

Conversation

fabrizzio-dotCMS
Copy link
Contributor

Isolating changes to investigate issues running CURL tests

@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as draft May 12, 2022 17:29
@fabrizzio-dotCMS fabrizzio-dotCMS changed the title #21619 cherry picking changes #21619 Testing changes on Config class May 13, 2022
@fabrizzio-dotCMS fabrizzio-dotCMS mentioned this pull request May 13, 2022
Closed
@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review May 13, 2022 16:10
@fabrizzio-dotCMS fabrizzio-dotCMS mentioned this pull request May 13, 2022
Closed
@fabrizzio-dotCMS fabrizzio-dotCMS changed the title #21619 Testing changes on Config class #21619 Changes on Config class May 13, 2022
@nollymar nollymar merged commit c668cdf into release-22.06 May 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue-21619-lazy-load-bool branch May 13, 2022 20:58
@nollymar nollymar linked an issue May 13, 2022 that may be closed by this pull request
ContentTypeFactoryImpl Getting Config values cause unneeded load #21619
Closed
jdotcms
jdotcms reviewed May 13, 2022
View reviewed changes
dotCMS/src/main/java/com/dotcms/contenttype/business/ContentTypeFactoryImpl.java
@@ -626,7 +628,8 @@ private boolean dbDelete(final ContentType type) throws DotDataException {
return true;
}

final boolean LOAD_FROM_CACHE=Config.getBooleanProperty("LOAD_CONTENTTYPE_DETAILS_FROM_CACHE", true);
final Lazy<Boolean> LOAD_FROM_CACHE=Lazy.of(()->Config.getBooleanProperty(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

oidacra pushed a commit that referenced this pull request Jun 13, 2022
@fabrizzio-dotCMS @oidacra
#21619 Changes on Config class (#22209)
292b66a 
* #21619 cherry picking changes

* #21619 adding logs for research

* #21619 fix on getBool

* #21619 fix on getBoolPropert test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nollymar nollymar nollymar approved these changes

@jcastro-dotcms jcastro-dotcms jcastro-dotcms approved these changes

@jdotcms jdotcms jdotcms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ContentTypeFactoryImpl Getting Config values cause unneeded load
4 participants
@fabrizzio-dotCMS @nollymar @jcastro-dotcms @jdotcms