Issue 24738 push files #25164

fabrizzio-dotCMS · 2023-06-06T21:01:36Z

Proposed Changes

New Resource that allows pulling info about our resources using site name and folder path structure
We can now push, pull, and delete files and or their versions. Specifying a file asset path
We try to replicate as much as possible the behavior presented by our Webdav endpoints

`🤖 Generated by Copilot at a8399fb`

The pull request adds new features and tests to the browser API and the web asset resource. It allows filtering folder content by file name, language, and status, and managing assets via the REST API. It also refactors some classes and adds javadoc comments and annotations. The main files affected are BrowserAPIImpl.java, WebAssetResource.java, AssetPathResolver.java, and their corresponding test classes.

`🤖 Generated by Copilot at a8399fb`

Add new endpoints for downloading, uploading, and deleting assets in the WebAssetResource class (link), using the WebAssetHelper class and the data classes from the asset package.

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/AbstractFileUploadParamsJson.java

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/FileUploadData.java

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetHelper.java

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java

jdotcms · 2023-06-06T21:20:02Z

In general we have some security stuff for upload file on the temp api
I am not sure if you should follow the temp api pattern or reimplement the rules here

… into issue-24738-push-files

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java

...integration-test/java/com/dotcms/rest/api/v1/asset/AssetPathResolverImplIntegrationTest.java

nollymar

@fabrizzio-dotCMS you should include your new tests to the MainSuite2b as well. The way tests are executed was modified for performance reasons

… into issue-24738-push-files

…ed with contentlet_version_info

… into issue-24738-push-files

dotcms-sonarqube · 2023-06-30T20:14:20Z

SonarQube Quality Gate

0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

* #24738 * #24738 pusg files * #24738 * #24738 * #24738 * #24738 file asset download endpoint * #24738 save point * #24738 fixes * #24738 fixing 404 * #24738 fix bug on pull * #24738 adding delete support + tests * #24738 adding doc * #24738 adding doc * #24738 many fixes bringing versions + initiating delete endpoint work * #fix postman * #24738 fix in tests * #24738 remove unnecessary class * #24738 fixing sub folder dups + IT for rchive and delete * #24738 fix conflict * #24738 archive file postman test * #24738 fix retrieving file versions * #24738 feedback * #24738 improve finding all versions * #24738 no dont to filter live or worrking if we get our versions joined with contentlet_version_info * #24738 order tests * #24738 change on the field we use to get to the asset * #24738 * #24738 solve conflict

fabrizzio-dotCMS and others added 4 commits May 25, 2023 16:08

#24738

db7c977

#24738 pusg files

f0fea21

#24738

e0494d5

Merge branch 'master' into issue-24738-push-files

6d1bfa9

jdotcms reviewed Jun 6, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/AbstractFileUploadParamsJson.java Outdated Show resolved Hide resolved

jdotcms reviewed Jun 6, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/FileUploadData.java Show resolved Hide resolved

jdotcms reviewed Jun 6, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetHelper.java Show resolved Hide resolved

jdotcms reviewed Jun 6, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java Show resolved Hide resolved

fabrizzio-dotCMS marked this pull request as draft June 6, 2023 21:19

fabrizzio-dotCMS and others added 11 commits June 7, 2023 09:59

#24738

2df0e8a

#24738

8df0fe9

#24738 file asset download endpoint

c185692

#24738 save point

14972d6

#24738 fixes

117b3bb

Merge branch 'master' into issue-24738-push-files

31a12df

#24738 fixing 404

28c3a5a

#24738 fix bug on pull

ccd6a2b

#24738 adding delete support + tests

cf1b8a4

#24738 adding doc

d3c58a9

Merge branch 'master' into issue-24738-push-files

a8399fb

fabrizzio-dotCMS marked this pull request as ready for review June 22, 2023 21:32

fabrizzio-dotCMS linked an issue Jun 22, 2023 that may be closed by this pull request

dotCMS CLI: Implement endpoint to push files to dotCMS #24738

Closed

5 tasks

fabrizzio-dotCMS and others added 7 commits June 22, 2023 15:46

#24738 adding doc

ac2af5a

Merge branch 'issue-24738-push-files' of https://github.com/dotCMS/core…

b994e33

… into issue-24738-push-files

Merge branch 'master' into issue-24738-push-files

e2b1c42

#24738 many fixes bringing versions + initiating delete endpoint work

15290b0

#fix postman

1481e35

Merge branch 'master' into issue-24738-push-files

200f080

#24738 fix in tests

1939f3a

#24738 archive file postman test

9fc4330

jdotcms reviewed Jun 27, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java Outdated Show resolved Hide resolved

jdotcms reviewed Jun 27, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java Show resolved Hide resolved

jdotcms reviewed Jun 27, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java Outdated Show resolved Hide resolved

jdotcms reviewed Jun 27, 2023

View reviewed changes

dotCMS/src/main/java/com/dotcms/rest/api/v1/asset/WebAssetResource.java Outdated Show resolved Hide resolved

jcastro-dotcms approved these changes Jun 27, 2023

View reviewed changes

nollymar reviewed Jun 27, 2023

View reviewed changes

...integration-test/java/com/dotcms/rest/api/v1/asset/AssetPathResolverImplIntegrationTest.java Outdated Show resolved Hide resolved

nollymar requested changes Jun 27, 2023

View reviewed changes

fabrizzio-dotCMS and others added 8 commits June 27, 2023 20:03

#24738 fix retrieving file versions

b3df45b

Merge branch 'master' into issue-24738-push-files

ac3b439

#24738 feedback

ee84636

Merge branch 'issue-24738-push-files' of https://github.com/dotCMS/core…

970a508

… into issue-24738-push-files

#24738 improve finding all versions

c5a888a

Merge branch 'master' into issue-24738-push-files

eebe8d5

#24738 no dont to filter live or worrking if we get our versions join…

d04d1a6

…ed with contentlet_version_info

Merge branch 'master' into issue-24738-push-files

7ce9359

jgambarios approved these changes Jun 29, 2023

View reviewed changes

fabrizzio-dotCMS and others added 6 commits June 29, 2023 11:21

#24738 order tests

7e22718

Merge branch 'issue-24738-push-files' of https://github.com/dotCMS/core…

1b25978

… into issue-24738-push-files

#24738 change on the field we use to get to the asset

dbd413c

Merge branch 'master' into issue-24738-push-files

81b4e2b

Merge branch 'master' into issue-24738-push-files

3d962f4

#24738

5d328b6

nollymar approved these changes Jun 30, 2023

View reviewed changes

fabrizzio-dotCMS and others added 2 commits June 30, 2023 13:42

Merge branch 'master' into issue-24738-push-files

e4a7883

#24738 solve conflict

a7070fe

nollymar merged commit 0365156 into master Jun 30, 2023

nollymar deleted the issue-24738-push-files branch June 30, 2023 21:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 24738 push files #25164

Issue 24738 push files #25164

fabrizzio-dotCMS commented Jun 6, 2023 •

edited by ghost

Loading

jdotcms commented Jun 6, 2023

nollymar left a comment

dotcms-sonarqube bot commented Jun 30, 2023

Issue 24738 push files #25164

Issue 24738 push files #25164

Conversation

fabrizzio-dotCMS commented Jun 6, 2023 • edited by ghost Loading

Proposed Changes

🤖 Generated by Copilot at a8399fb

🤖 Generated by Copilot at a8399fb

jdotcms commented Jun 6, 2023

nollymar left a comment

Choose a reason for hiding this comment

dotcms-sonarqube bot commented Jun 30, 2023

fabrizzio-dotCMS commented Jun 6, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at a8399fb`

`🤖 Generated by Copilot at a8399fb`