Issue 25184 adding systemtable resource #25470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezell
reviewed
Jul 12, 2023
dotCMS/src/main/java/com/dotcms/business/SystemTableFactoryImpl.java
Outdated
Show resolved
Hide resolved
wezell
requested changes
Jul 12, 2023
dotCMS/src/main/java/com/dotcms/business/SystemTableFactoryImpl.java
Outdated
Show resolved
Hide resolved
dotCMS/src/main/java/com/dotcms/rest/api/v1/system/SystemTableResource.java
Show resolved
Hide resolved
freddyucv
approved these changes
Jul 20, 2023
wezell
approved these changes
Jul 20, 2023
| @Override | ||
| public void executeUpgrade() throws DotDataException, DotRuntimeException { | ||
|
|
||
| Try.of(()->new DotConnect().executeStatement("CREATE TABLE system_table (" |
There was a problem hiding this comment.
We should always add IF NOT EXISTS when adding tables, e.g. CREATE TABLE IF NOT EXISTS system_table
There was a problem hiding this comment.
thinking about 2 nodes coming up up a cluster simultaneously.
manuelrojas
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the system table resource