Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLI): Adding views so we can have different versions of the json… #25830

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented Aug 18, 2023

… Refs: #25800

Proposed Changes

  • We need to include a workflow attribute that constitutes an array of identifiers.
  • This array should only be sent when updating or creating a CT
  • When Pulling the CT it should not be generated
  • Our new WebAssetsResoucre depends on the System-Workflow associated to the FileAsset CT we need to make this code more resilient capable of surviving when no System Workflow is present
  • SiteCommand and ContentTypeComand paginations were using 0 as starting index. Therefore the first page would appear twice. It needed to be set to 1

@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review August 21, 2023 21:49
@dotcms-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@nollymar nollymar merged commit e689dc0 into master Aug 24, 2023
@nollymar nollymar deleted the issue-25800-fix-sending-workflows-on-ct branch August 24, 2023 03:30
@nollymar nollymar linked an issue Aug 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants