Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 26001 implement sync feature for content types #26312

Merged
merged 9 commits into from
Sep 29, 2023

Conversation

jgambarios
Copy link
Contributor

@jgambarios jgambarios commented Sep 28, 2023

Improving the push command for content types. Now the push command for content types can handle, new content types, editing of existing content types, and removals.

🤖 Generated by Copilot at 8fffb85

Refactored the Field and ContentType models to use default values and annotations, improved the test coverage and output of the content type, language, and site commands, and added new classes and mixins to support the content type push command with pagination, folders, workspaces, and removal options.

🤖 Generated by Copilot at 8fffb85

  • Change the getContentTypes method in the ContentTypeAPI interface to use per_page instead of perPage as the query parameter name (link)
  • Add the ContentTypeComparator, ContentTypeFetcher, and ContentTypePushHandler classes to implement the logic for comparing, fetching, and pushing content types to the server (link, link, link)
  • Modify the ContentTypePush class to extend the DotPush interface and use the new classes and mixins to support pushing a folder of content types and removing content types on the server (link, link, link)
  • Add the ContentTypePushMixin class to define the --removeContentTypes option for the ContentTypePush command (link)
  • Change the abstract methods in the Field and ContentType classes to use @Value.Default and @Value.Auxiliary annotations to provide default values and avoid null values (link, link, link, link, link, link, link, link, link, link)
  • Change the methods in the Workflow interface to use @Value.Default annotations to provide default values and avoid null values (link, link, link)
  • Add the Test_Command_Content_Type_Folder_Push method to test the functionality of the content type push command when pushing a folder of content types (link)
  • Change the test methods in the ContentTypeCommandIntegrationTest class to create a temporary folder for the workspace, use the --fail-fast and -e options for the push command, and use the RestClientFactory, MapperService, and ResponseEntityView classes for the API calls (link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Change the header of the LanguagePush and SitePush commands to use plural instead of singular (link, link)
  • Fix the missing output stream and add assertions for the output messages in the Test_Command_Language_Pull_Then_Push_YML method (link, link, link, link, link)
  • Fix the missing output stream in the Test_Command_Site_Pull_Then_Push_YML method (link)

@jgambarios jgambarios marked this pull request as ready for review September 28, 2023 19:22
@jgambarios jgambarios linked an issue Sep 28, 2023 that may be closed by this pull request
@nollymar nollymar merged commit a9b8729 into master Sep 29, 2023
@nollymar nollymar deleted the issue-26001-Implement-sync-feature-for-content-types branch September 29, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "sync" feature for content types
3 participants