Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edit-ema): Enable DnD of content types to create content #27012

Merged
merged 31 commits into from
Dec 19, 2023
Merged

feat(edit-ema): Enable DnD of content types to create content #27012

merged 31 commits into from
Dec 19, 2023

Conversation

fmontes
Copy link
Member

@fmontes fmontes commented Dec 14, 2023

Proposed Changes

TBD

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

fmontes added 23 commits December 13, 2023 19:56
@fmontes
feat(edit-ema): Enable DnD of content types to create content
f60f8d1
@fmontes
Clean up and show dropzone when boxes
3dff4a7
@fmontes
Clean up scroll event
b6a9b50
@fmontes
Pass the data on drop
b42cd94
@fmontes
Drop contentlet working
d16c211
@fmontes
Reload with useRouter
ad11ec6
@fmontes
Clean up
574e780
@fmontes
Add positioned contentlet insertion in container
5f9cbcf
@fmontes
Add pointer to the contentlets
fa69b13
@fmontes
Merge branch 'master' into issue-27001-dnd-palette-edit-ema
9e50c72
@fmontes
Clean up models
5ad7343
@fmontes
Move interfaces to shared models
59b573b
@fmontes
Open dialog to create content from palette
cb5b812
@fmontes
Clean up store
9fb9e09
@fmontes
Fix tests in ema store
b01088f
@fmontes
Create contentlet from palette
df6cd8e
@fmontes
Add createContentFromPalette and setDialgo test case to EditEmaStore
7dde208
@fmontes
Clean up test and make it green
9908ec4
@fmontes
Fix the last test in the component
3af06d2
@fmontes
Add documentation
0fa42ef
@fmontes
Add tests for dropzone in the editor
c6dc849
@fmontes
Move dropzone to ema component
1597988
@fmontes
Tests for dropzone
9d54c75
@fmontes fmontes marked this pull request as ready for review December 19, 2023 04:00
@fmontes fmontes requested review from zJaaal, rjvelazco and a team December 19, 2023 04:43
@fmontes fmontes requested review from manuelrojas and KevinDavilaDotCMS and removed request for a team December 19, 2023 04:43
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@fmontes fmontes added this pull request to the merge queue Dec 19, 2023
Merged via the queue into master with commit 7fc555e Dec 19, 2023
@fmontes fmontes deleted the issue-27001-dnd-palette-edit-ema branch December 19, 2023 19:16
@fmontes fmontes linked an issue Dec 19, 2023 that may be closed by this pull request
Edit EMA: Enable Drag and Drop Content Types To Create New Contentlets #27001
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zJaaal zJaaal zJaaal approved these changes

@KevinDavilaDotCMS KevinDavilaDotCMS KevinDavilaDotCMS approved these changes

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

@manuelrojas manuelrojas Awaiting requested review from manuelrojas manuelrojas was automatically assigned from dotCMS/frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit EMA: Enable Drag and Drop Content Types To Create New Contentlets
4 participants
@fmontes @manuelrojas @zJaaal @KevinDavilaDotCMS