feat(edit-ema): #26988 Add layout editor #27014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect-contentlet-dialog
…t-dialog' of https://github.com/dotCMS/core into 26916-edit-ema-create-contentlets-from-select-contentlet-dialog
…ect-contentlet-dialog
…ect-contentlet-dialog
… for adding a contentlet
…ect-contentlet-dialog
…ect-contentlet-dialog
…ect-contentlet-dialog
…t-dialog' into 26965-edit-ema-add-right-nav-toolbar
fmontes
requested changes
Dec 19, 2023
core-web/libs/portlets/dot-ema/src/lib/dot-ema-shell/dot-ema.component.html
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/dot-ema-shell/dot-ema.component.scss
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/dot-ema-shell/dot-ema.component.spec.ts
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/edit-ema-layout/edit-ema-layout.component.spec.ts
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/edit-ema-layout/edit-ema-layout.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/edit-ema-layout/edit-ema-layout.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/edit-ema-layout/edit-ema-layout.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
requested review from
oidacra,
manuelrojas,
hmoreras and
KevinDavilaDotCMS
…https://github.com/dotCMS/core into 26988-edit-ema-render-the-template-builder-in-layout
fmontes
approved these changes
Dec 20, 2023
|
0.0% Coverage on New Code
0.0% Duplication on New Code
KevinDavilaDotCMS
approved these changes
Dec 20, 2023
fmontes
changed the title
fmontes
deleted the
26988-edit-ema-render-the-template-builder-in-layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed
DotRouterServiceand dependencies tolibsCanDeactivateGuardtolibsedit-pageScreenshots
Screen.Recording.2023-12-20.at.1.01.23.PM.mov