Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(edit-ema): #26997 Add page properties functionality #27111

Merged
merged 3 commits into from
Dec 27, 2023
Merged

feat(edit-ema): #26997 Add page properties functionality #27111

merged 3 commits into from
Dec 27, 2023

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Dec 26, 2023

Proposed Changes

  • Add a dialog to the shell and use the same logic as in editor.
  • Adapt the store to handle the opening and closing of dialogs by context (editor or shell at the moment)
  • Add test cases
  • Send a timestamp in the iframeURL to trigger a reload when the queryParams do not update. This happens when we edit the page properties. We need to force a reload but we didn't changed any queryParam, so we send a timestamp as a flag to reload.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Screenshots

Screen.Recording.2023-12-26.at.5.44.44.PM.mov

@zJaaal zJaaal linked an issue Dec 26, 2023 that may be closed by this pull request
Edit EMA: Allow Users to Edit Page Properties #26997
Closed
@zJaaal zJaaal requested a review from fmontes December 27, 2023 14:07
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@fmontes fmontes changed the title Fix #26997: Edit EMA add page properties functionality feat(edit-ema): #26997 Add page properties functionality Dec 27, 2023
@fmontes fmontes added this pull request to the merge queue Dec 27, 2023
Merged via the queue into master with commit 75c0eba Dec 27, 2023
@fmontes fmontes deleted the 26997-edit-ema-allow-users-to-edit-page-properties branch December 27, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmontes fmontes fmontes approved these changes

@oidacra oidacra oidacra approved these changes

@manuelrojas manuelrojas manuelrojas approved these changes

@hmoreras hmoreras hmoreras approved these changes

@KevinDavilaDotCMS KevinDavilaDotCMS KevinDavilaDotCMS approved these changes

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit EMA: Allow Users to Edit Page Properties
6 participants
@zJaaal @fmontes @oidacra @manuelrojas @hmoreras @KevinDavilaDotCMS