Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edit-ema): Enable Edit Mode in EMA when Editor is present (#27278) #27287

Merged
merged 21 commits into from
Jan 10, 2024
Merged

fix(edit-ema): Enable Edit Mode in EMA when Editor is present (#27278) #27287

merged 21 commits into from
Jan 10, 2024

Conversation

zJaaal
Copy link
Contributor

@zJaaal zJaaal commented Jan 8, 2024 •
edited
Loading

Proposed changes

  • Add a Ping-Pong mechanism as handshake to know whether to hide or not the events and attributes that we use to communicate the editor with the customer page

Screenshot

Screen.Recording.2024-01-09.at.1.31.34.PM.mov

@zJaaal zJaaal linked an issue Jan 8, 2024 that may be closed by this pull request
Edt EMA: Enable Edit Mode for Customer Pages #27278
Closed
@zJaaal zJaaal marked this pull request as ready for review January 9, 2024 15:56
@zJaaal zJaaal changed the title Fix #27278: Edit EMA enable Edit Mode when Editor Fix #27278: Edit EMA enable Edit Mode when Editor is present Jan 9, 2024
@zJaaal zJaaal requested a review from manuelrojas January 9, 2024 16:32
@zJaaal zJaaal linked an issue Jan 10, 2024 that may be closed by this pull request
Edit EMA: Add functionality for empty containers #27301
Closed
@zJaaal zJaaal removed a link to an issue Jan 10, 2024
Edit EMA: Add functionality for empty containers #27301
Closed
@fmontes fmontes changed the title Fix #27278: Edit EMA enable Edit Mode when Editor is present fix(edit-ema): Enable Edit Mode in EMA when Editor is present (#27278) Jan 10, 2024
@fmontes fmontes enabled auto-merge January 10, 2024 18:23
@fmontes fmontes added this pull request to the merge queue Jan 10, 2024
Merged via the queue into master with commit 0a534c7 Jan 10, 2024
15 checks passed
@fmontes fmontes deleted the 27278-edt-ema-enable-edit-mode-for-customer-pages branch January 10, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmontes fmontes fmontes approved these changes

@KevinDavilaDotCMS KevinDavilaDotCMS KevinDavilaDotCMS approved these changes

@oidacra oidacra Awaiting requested review from oidacra

@hmoreras hmoreras Awaiting requested review from hmoreras

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

@manuelrojas manuelrojas Awaiting requested review from manuelrojas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edt EMA: Enable Edit Mode for Customer Pages
3 participants
@zJaaal @fmontes @KevinDavilaDotCMS