Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Edit Page ask to copy non-existent language page #27281 #27311

Merged
merged 7 commits into from
Jan 16, 2024
Merged

feat(core): Edit Page ask to copy non-existent language page #27281 #27311

merged 7 commits into from
Jan 16, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Jan 10, 2024 •
edited
Loading

Proposed Changes

  • Confirm to auto-fill innexistent language with the current language on Page

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

Screen.Recording.2024-01-10.at.12.16.20.PM.mov

@oidacra oidacra linked an issue Jan 10, 2024 that may be closed by this pull request
Edit Page: Resolve Error When Editing Non-Existent Language Page #27281
Closed
fmontes
fmontes reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@fmontes fmontes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@oidacra oidacra force-pushed the issue-27281-resolve-error-page-not-exist-lang branch from b01370c to 4988c40 Compare January 11, 2024 23:24
@oidacra oidacra changed the title feat(edit-page) ask to copy non-existent language page dotCMS/core#27281 Edit Page ask to copy non-existent language page Jan 11, 2024
@oidacra oidacra marked this pull request as ready for review January 11, 2024 23:25
@oidacra oidacra force-pushed the issue-27281-resolve-error-page-not-exist-lang branch from 13619bc to ba412b4 Compare January 12, 2024 04:54
@oidacra oidacra requested a review from fmontes January 12, 2024 21:48
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@fmontes fmontes changed the title dotCMS/core#27281 Edit Page ask to copy non-existent language page feat(core): Edit Page ask to copy non-existent language page #27281 Jan 16, 2024
@fmontes fmontes added this pull request to the merge queue Jan 16, 2024
Merged via the queue into master with commit ddd7297 Jan 16, 2024
41 checks passed
@fmontes fmontes deleted the issue-27281-resolve-error-page-not-exist-lang branch January 16, 2024 14:28
@oidacra oidacra restored the issue-27281-resolve-error-page-not-exist-lang branch January 18, 2024 21:39
@rjvelazco rjvelazco mentioned this pull request Feb 9, 2024
Closed
@fmontes fmontes mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmontes fmontes fmontes approved these changes

@zJaaal zJaaal zJaaal approved these changes

@manuelrojas manuelrojas Awaiting requested review from manuelrojas

@hmoreras hmoreras Awaiting requested review from hmoreras

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Page: Resolve Error When Editing Non-Existent Language Page
3 participants
@oidacra @fmontes @zJaaal