Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementantion(fix): #29534 Login-as popup show's in the incorrect position. #29631

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

hmoreras
Copy link
Contributor

@hmoreras hmoreras commented Aug 16, 2024

Proposed Changes

  • Hide mask when menu close.

Before

Screenshare.-.2024-08-16.5_10_00.PM.mp4

After

Screenshare.-.2024-08-16.5_10_47.PM.mp4

@hmoreras hmoreras linked an issue Aug 16, 2024 that may be closed by this pull request
@hmoreras hmoreras enabled auto-merge August 16, 2024 23:20
Copy link
Contributor

@nicobytes nicobytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmoreras hmoreras added this pull request to the merge queue Aug 20, 2024
Merged via the queue into master with commit e463b7b Aug 20, 2024
18 checks passed
@hmoreras hmoreras deleted the issue-29534 branch August 20, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login-as popup show's in the incorrect position.
3 participants