Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimeNG v17: Fix p-dataview breaking change #29658

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Aug 20, 2024

Parent Issue

#29657

Proposed Changes

  • Fix error with breaking change by PrimeNg V17 upgrade

gridItem and listItem templates are deprecated and will removed in the future, use list and grid templates instead.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Screenshots

v15 v17
Screenshot 2024-08-20 at 9 25 49 AM Screenshot 2024-08-20 at 9 25 34 AM
Screenshot 2024-08-09 at 6 39 25 PM Screenshot 2024-08-09 at 6 10 06 PM
DotCMS/ThemeSelector DotCMS/ThemeSelector
Screenshot 2024-08-20 at 11 25 41 AM Screenshot 2024-08-20 at 11 25 34 AM
Screenshot 2024-08-20 at 5 13 29 PM Screenshot 2024-08-20 at 5 11 52 PM
Screenshot 2024-08-20 at 5 13 38 PM Screenshot 2024-08-20 at 5 12 13 PM

This PR fixes: #29657

@nicobytes nicobytes changed the title 29657 fix breaking change PrimeNG v17: Fix p-dataview breaking change Aug 20, 2024
@nicobytes nicobytes mentioned this pull request Aug 20, 2024
9 tasks
@nicobytes nicobytes linked an issue Aug 20, 2024 that may be closed by this pull request
@nicobytes nicobytes changed the base branch from master to epic-primeng-upgrade August 20, 2024 14:24
@nicobytes nicobytes marked this pull request as ready for review August 20, 2024 21:22
@nicobytes nicobytes merged commit 6810af6 into epic-primeng-upgrade Aug 21, 2024
1 check passed
@nicobytes nicobytes deleted the 29657-fix-breaking-change branch August 21, 2024 14:58
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
### Parent Issue
#29058


### Objective

This is a PR to collect small PRs to upgrade from PrimeNG v15 to v17.

### PRs associated

- [x] #29057
- [x] #29624
- [x] #29562
- [x] #29650
- [x] #29658
- [x] #29674
- [x] #29704
- [x] #29706
- [x] #29737

---------

Co-authored-by: Arcadio Quintero <[email protected]>
Co-authored-by: spbolton <[email protected]>
Co-authored-by: Victor Alfaro <[email protected]>
Co-authored-by: Humberto Morera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrimeNG v17: Fix p-dataview breaking change
3 participants