chore: Improve the Angular example #29780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontes
commented
Aug 29, 2024
fmontes
commented
Aug 29, 2024
zJaaal
requested changes
Aug 29, 2024
zJaaal
approved these changes
Aug 29, 2024
zJaaal
approved these changes
Aug 30, 2024
nicobytes
reviewed
Sep 2, 2024
examples/angular/src/app/pages/components/loading/loading.component.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Sep 3, 2024
rjvelazco
approved these changes
Sep 3, 2024
nicobytes
approved these changes
Sep 4, 2024
nicobytes
reviewed
Sep 4, 2024
|
1 task
dsolistorres
pushed a commit
that referenced
this pull request
Sep 18, 2024
### Proposed Changes - Remove guard - Remove resolver - Simplify the router - Add error for auth - Add loading state while fetching the page and navigating - Unify editor config to pass to page component - Cache navigation request so it's not fetched on every page load ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info ** any additional useful context or info ** ### Screenshots Original | Updated :-------------------------:|:-------------------------: ** original screenshot ** | ** updated screenshot **
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots