-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): e2e setup for the new content editor #31044
chore(e2e): e2e setup for the new content editor #31044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 17 changed files in this pull request and generated 1 comment.
Files not reviewed (11)
- e2e/dotcms-e2e-node/frontend/package.json: Language not supported
- e2e/dotcms-e2e-node/frontend/locators/globalLocators.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/contentSearch/contentEditing.spec.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/utils/contentUtils.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/contentSearch/portletIntegrity.spec.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/login/login.spec.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/contentSearch/contentData.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/locators/navigation/menuLocators.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/utils/dotCMSUtils.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/utils/api.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/pages/newEditContentForm.page.ts: Evaluated as low risk
Comments suppressed due to low confidence (4)
e2e/dotcms-e2e-node/frontend/tests/editContent/newEditContent.spec.ts:7
- Ensure that the generated word is valid and appropriate for use as a content type name.
const contentTypeName = faker.lorem.word().toLocaleLowerCase();
e2e/dotcms-e2e-node/frontend/tests/editContent/newEditContent.spec.ts:15
- [nitpick] Check if this call to goToUrl is necessary as it is called again on line 21.
await listingContentTypesPage.goToUrl();
e2e/dotcms-e2e-node/frontend/tests/editContent/newEditContent.spec.ts:33
- Ensure that the generated word is valid and appropriate for use as a text field value.
const textFieldValue = faker.lorem.word();
e2e/dotcms-e2e-node/frontend/pages/listngContent.page.ts:0
- The file name 'listngContent.page.ts' contains a typo. It should be 'listingContent.page.ts'.
index main..branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (11)
- e2e/dotcms-e2e-node/frontend/package.json: Language not supported
- e2e/dotcms-e2e-node/frontend/locators/globalLocators.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/contentSearch/contentEditing.spec.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/utils/contentUtils.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/contentSearch/portletIntegrity.spec.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/contentSearch/contentData.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/tests/login/login.spec.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/locators/navigation/menuLocators.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/utils/dotCMSUtils.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/pages/textField.page.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/pages/newEditContentForm.page.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)
e2e/dotcms-e2e-node/frontend/pages/listingContentTypes.pages.ts:46
- [nitpick] The locator 'getByLabel("Content")' might be ambiguous. Consider using a more specific locator to avoid potential issues.
await this.page.getByLabel("Content").locator("a").click();
e2e/dotcms-e2e-node/frontend/pages/listngContent.page.ts:0
- The filename 'listngContent.page.ts' contains a typo. It should be 'listingContent.page.ts'.
filename
e2e/dotcms-e2e-node/frontend/pages/listngContent.page.ts:5
- The private fields '#addBtn' and '#addNewContent' should use the 'private' keyword instead of the '#' syntax.
#addBtn = this.page.locator("span[widgetid='dijit_form_DropDownButton_0']");
…of github.com:dotCMS/core into 31033-end-to-end-e2e-setup-for-the-new-content-editor
Parent Issue
#31033
Proposed Changes
This pull request includes various changes primarily focused on code formatting, adding new locators, and introducing new page classes for the end-to-end tests. The most important changes include reformatting the code for consistency, adding new locators for different elements, and creating new page classes to handle content type forms and listings.
Code Formatting and Consistency:
e2e/dotcms-e2e-node/frontend/locators/globalLocators.ts
ande2e/dotcms-e2e-node/frontend/locators/navigation/menuLocators.ts
for better readability and consistency. [1] [2]New Locators:
CONTENT_MODEL
inGroupEntriesLocators
and adjusted existing locators inToolEntriesLocators
andMenuEntriesLocators
ine2e/dotcms-e2e-node/frontend/locators/navigation/menuLocators.ts
. [1] [2] [3]New Page Classes:
ContentTypeFormPage
,ListingContentTypesPage
,ListingContentPage
,NewEditContentFormPage
, andTextFieldPage
classes to handle various functionalities related to content types and their forms ine2e/dotcms-e2e-node/frontend/pages/
. [1] [2] [3] [4] [5]Package and Script Updates:
@faker-js/faker
dependency and updated thestart
script to include--ui
flag ine2e/dotcms-e2e-node/frontend/package.json
. [1] [2]Test File Adjustments:
contentEditing.spec.ts
andcontentData.ts
ine2e/dotcms-e2e-node/frontend/tests/contentSearch/
. [1] [2] [3] [4] [5] [6]Checklist
Screenshots
This PR fixes: #31033