chore(edit-content): add site field to search relationships #31298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (5)
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/components/site-field/site-field.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/components/site-field/site-field.component.scss: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/search.compoment.html: Language not supported
- dotCMS/src/main/webapp/WEB-INF/messages/Language.properties: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/search/search.component.spec.ts: Evaluated as low risk
...ents/dot-select-existing-content/components/search/components/site-field/site-field.store.ts
Outdated
Show resolved
Hide resolved
...ents/dot-select-existing-content/components/search/components/site-field/site-field.store.ts
Outdated
Show resolved
Hide resolved
oidacra
approved these changes
Feb 3, 2025
hmoreras
approved these changes
Feb 3, 2025
search.mp4 |
nicobytes
deleted the
31280-relationship-field-search-site-or-host-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#31280
Proposed Changes
This pull request introduces a new
SiteFieldComponentfor selecting a site from a tree structure in thedot-edit-content-relationship-fieldmodule. The changes include the implementation of the component, its associated styles, unit tests, and a store for managing the component's state.Key changes:
Component Implementation:
site-field.component.ts: Added theSiteFieldComponentwhich implementsControlValueAccessorto work with Angular forms and uses PrimeNG'sTreeSelectcomponent for the UI.site-field.component.html: Created the template for theSiteFieldComponentusingp-treeSelectfor the tree structure and added error handling.site-field.component.scss: Added styles to ensure theTreeSelectcomponent spans the full width of its container.Unit Tests:
site-field.component.spec.ts: Added comprehensive unit tests for theSiteFieldComponent, covering initial state, control value accessor implementation, and edge cases.site-field.store.spec.ts: Added unit tests for theSiteFieldStore, ensuring proper loading of sites, handling of errors, and state management.Checklist
This PR fixes: #31280