feat(binaryField): Add support for VTL Syntax Highlight #31365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
zJaaal
requested review from
valentinogiardino and
rjvelazco
and removed request for
valentinogiardino
zJaaal
requested review from
fmontes,
hmoreras,
valentinogiardino,
KevinDavilaDotCMS,
oidacra and
nicobytes
oidacra
reviewed
Feb 12, 2025
...src/lib/fields/dot-edit-content-binary-field/components/dot-binary-field-editor/languages.ts
Outdated
Show resolved
Hide resolved
zJaaal
changed the title
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
fmontes
approved these changes
Feb 12, 2025
oidacra
approved these changes
Feb 12, 2025
rjvelazco
approved these changes
Feb 12, 2025
hmoreras
approved these changes
Feb 12, 2025
zJaaal
changed the title
…-new-code-editor-modal
zJaaal
deleted the
31300-vtl-syntax-highlighting-missing-in-the-new-code-editor-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new custom language for Monaco Editor and refactors the existing code to support this language. The most important changes include adding the HTML base tokenizer, defining the Velocity language, and updating the relevant components to use the new language.
New Language Support:
html-monaco-language-base.tsto provide basic HTML syntax highlighting.velocity-monaco-language.tsand integrated HTML tokenizer for comprehensive syntax support.Component Updates:
dot-binary-field-editor.component.tsto register and set the new Velocity language for.vtlfiles. [1] [2] [3]dot-binary-field-editor.component.spec.tsto reflect the language change from HTML to Velocity.Code Cleanup:
dot-wysiwyg-monaco/custom-languages/velocity-monaco-language.ts.dot-wysiwyg-monaco.component.tsandtsconfig.json. [1] [2]Screenshots
Screen.Recording.2025-02-12.at.4.21.13.PM.mov
Screen.Recording.2025-02-12.at.4.20.22.PM.mov
This PR fixes: #31300