-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(editor-content): Reorder items in relationship field #31389
chore(editor-content): Reorder items in relationship field #31389
Conversation
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html: Language not supported
- e2e/dotcms-e2e-node/frontend/pages/textField.page.ts: Evaluated as low risk
- e2e/dotcms-e2e-node/frontend/data/defaultContentType.ts: Evaluated as low risk
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
Parent Issue
#31383
Proposed Changes
This pull request includes several changes to the
dot-edit-content-relationship-field
component and its associated store and tests. The primary focus is on simplifying the data handling methods and updating the UI for better consistency.Changes to UI elements:
dot-edit-content-relationship-field.component.html
).Changes to data handling methods:
addData
andreorderData
methods withsetData
method to streamline data updates (dot-edit-content-relationship-field.component.ts
). [1] [2]addData
andreorderData
methods from the store, consolidating data updates into thesetData
method (relationship-field.store.ts
). [1] [2]Changes to tests:
addData
andreorderData
methods since these methods are no longer used (relationship-field.store.spec.ts
). [1] [2]Checklist
Additional Info
** any additional useful context or info **
Screenshots
This PR fixes: #31383