fix(Page) Working/Live Images loading inconsistenly Refs: 31362 #31408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/dotCMS/core into issue-31362-inconsisten-image-swithing-mode
…/github.com/dotCMS/core into issue-31362-inconsisten-image-swithing-mode
…/github.com/dotCMS/core into issue-31362-inconsisten-image-swithing-mode
|
Please use a Conventional Commit title format for this PR. For more information, see https://www.conventionalcommits.org/en/v1.0.0/ |
freddyDOTCMS
approved these changes
Feb 18, 2025
jdotcms
reviewed
Feb 18, 2025
dotCMS/src/main/java/com/dotcms/rendering/velocity/servlet/VelocityServlet.java
Show resolved
Hide resolved
jdotcms
reviewed
Feb 18, 2025
dotCMS/src/main/java/com/dotmarketing/servlets/BinaryExporterServlet.java
Show resolved
Hide resolved
jdotcms
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
if(!isAdmin) {serve the image with cache} else { do not use cache to serve the image}
The general rule is if we're in admin mode we do not serve images using cache. The bug was that when serving content in LIVE mode from within the UVE it would assume we were not on admin therefore the images would stay in cache
This PR fixes: #31362