Fluter freezed v3.0.0 #14
Conversation
|
Work is in progress on this issue here |
The previous version used classes to store instances of the Freezed Blocks and mutated its properties with setters which made it hard to test the plugin and also made it hard to identify state changes caused by side-effects. This version throws all the setters and use static methods and functions that only do one thing DefaultFreezedConfig and DefaultFlutterFreezedPluginConfig classes have been removed, all setters on the blocks have been removed
|
When will this be merged? |
|
@charlypoly Why is the PR failing the tests? I am pretty sure all my tests pass. Could you look into that for me please? |
| import { FlutterFreezedPluginConfig } from './config'; | ||
| import { schemaVisitor } from './schema-visitor'; | ||
| import { buildImportStatements, defaultFreezedPluginConfig } from './utils'; |
There was a problem hiding this comment.
@Parables all relative imports should end with a .js (for ESM support)
This is what is causing the CI tests to fail
There was a problem hiding this comment.
Thanks very much for the feedback
|
@denes16 @charlypoly @endigo @auaicn, I seriously need your feedback on these new breaking features. Clone this repo where I do all my crazy experimentation before releasing them for this plugin In an attempt to make the plugin more flexible for any use case, and provide more features to enhance the DevX of using GraphQL in Flutter projects, I have introduced some features but I fear I might be over-engineering something that nobody will ever use. I have been working on this straight for a month now and I feel no one is going to ever need these features I am going sleepless nights working on. |
|
I thought I was going crazy with these new features I was implementing but am I proud I did. What's new and upcoming in this plugin is modular configuration using specific patterns. Watch out for flutter-freezed-v4.0.0 @charlypoly I will need you to review this PR. |
Related # (issue)
dotansimha/graphql-code-generator#8350 (comment)