Response Cache plugin with small changes for better type-safety

[ardatan]

See the changesets
https://github.com/dotansimha/graphql-yoga/pull/1359/files

I am open for discussions about passing params and request instead of context in sessionId factory.

We need some unit tests for the new sessionId factory and to make sure execute, validate or even parse are never called before this plugin returns the cached response.

Need docs

[changeset-bot]

🦋 Changeset detected

Latest commit: a0026b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@graphql-yoga/common	Minor
@graphql-yoga/plugin-response-cache	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 112576      ✗ 0    
     data_received..................: 15 MB   499 kB/s
     data_sent......................: 6.5 MB  216 kB/s
     http_req_blocked...............: avg=2.12µs   min=1.2µs   med=1.7µs   max=2.74ms  p(90)=2.29µs  p(95)=2.66µs  
     http_req_connecting............: avg=32ns     min=0s      med=0s      max=1.84ms  p(90)=0s      p(95)=0s      
   ✓ http_req_duration..............: avg=416.2µs  min=253.8µs med=365.1µs max=21.95ms p(90)=476.2µs p(95)=586.2µs 
       { expected_response:true }...: avg=416.2µs  min=253.8µs med=365.1µs max=21.95ms p(90)=476.2µs p(95)=586.2µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 56288
     http_req_receiving.............: avg=29.52µs  min=16.2µs  med=24.7µs  max=9.28ms  p(90)=35.9µs  p(95)=41.2µs  
     http_req_sending...............: avg=12.09µs  min=6.1µs   med=8.3µs   max=4.87ms  p(90)=19µs    p(95)=20.5µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=374.58µs min=226.4µs med=328.1µs max=21.83ms p(90)=425.4µs p(95)=536.57µs
     http_reqs......................: 56288   1876.177746/s
     iteration_duration.............: avg=525.69µs min=322.1µs med=472.6µs max=24.19ms p(90)=601.6µs p(95)=709.9µs 
     iterations.....................: 56288   1876.177746/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

[github-actions]

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

[ardatan]

Because we don't have an access to the context from buildResponseCacheKey

[n1ru4l]

New envelop response-cache plugin is released, I think you can use it and then also change the target branch here to v3.

[n1ru4l]

I think for mutation and subscription operations we don't really need to lookup in the cache. However, we would need to already parse the string in order to reliably detect whether the operation is a mutation 🤔.
Maybe a simple regex operation could help here?

[n1ru4l]

It is the best because I fixed it