Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate leaks tests #1888

Merged
merged 12 commits into from
Nov 1, 2022
Merged

Separate leaks tests #1888

merged 12 commits into from
Nov 1, 2022

Conversation

enisdenjo
Copy link
Collaborator

@enisdenjo enisdenjo commented Oct 12, 2022

Closes #1839

Instead of "skipping" some tests for leak detection as a part of integration tests; separate the leaks tests and skip leaking ones over there, while leaving integration tests intact.

  • New command pnpm test:leaks
  • Drop --forceExit flag because we already --detectOpenHandles
  • Doesn't sacrifice DX, you can still pnpm test http.spec or pnpm test:integration file-uploads.spec

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

⚠️ No Changeset found

Latest commit: 491dbda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@enisdenjo enisdenjo self-assigned this Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20221101165827-1fc386d7 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 164338      ✗ 0    
     data_received..................: 25 MB   816 kB/s
     data_sent......................: 9.4 MB  315 kB/s
     http_req_blocked...............: avg=1.24µs   min=800ns   med=1.1µs   max=408.9µs p(90)=1.6µs   p(95)=1.9µs  
     http_req_connecting............: avg=1ns      min=0s      med=0s      max=108.7µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=287.51µs min=199.9µs med=261.7µs max=17.93ms p(90)=323.7µs p(95)=345.5µs
       { expected_response:true }...: avg=287.51µs min=199.9µs med=261.7µs max=17.93ms p(90)=323.7µs p(95)=345.5µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 82169
     http_req_receiving.............: avg=19.42µs  min=11.2µs  med=18µs    max=8.4ms   p(90)=23.9µs  p(95)=26.5µs 
     http_req_sending...............: avg=7.54µs   min=4.1µs   med=5.4µs   max=1.99ms  p(90)=10.9µs  p(95)=11.7µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=260.53µs min=180.3µs med=236.3µs max=17.78ms p(90)=292.4µs p(95)=311.5µs
     http_reqs......................: 82169   2738.832148/s
     iteration_duration.............: avg=358.43µs min=254.2µs med=329.4µs max=18.47ms p(90)=407.7µs p(95)=432.5µs
     iterations.....................: 82169   2738.832148/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://ed1a05e8.graphql-yoga.pages.dev

@enisdenjo enisdenjo force-pushed the seperate-leak-tests branch from 5604250 to 491dbda Compare November 1, 2022 16:57
@enisdenjo enisdenjo merged commit 6563dbb into v3 Nov 1, 2022
@enisdenjo enisdenjo deleted the seperate-leak-tests branch November 1, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants