Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JWT] allow getToken to return a promise #3029

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

EmrysMyrddin
Copy link
Collaborator

fixes #3028

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: df075d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-jwt Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 362480      ✗ 0     
     data_received................................: 1.5 GB  12 MB/s
     data_sent....................................: 73 MB   610 kB/s
     http_req_blocked.............................: avg=1.49µs   min=900ns    med=1.3µs    max=834.98µs p(90)=1.8µs    p(95)=2.1µs   
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=114.9µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=427.75µs min=206.49µs med=347.09µs max=29.29ms  p(90)=643.09µs p(95)=696.59µs
       { expected_response:true }.................: avg=427.75µs min=206.49µs med=347.09µs max=29.29ms  p(90)=643.09µs p(95)=696.59µs
     ✓ { mode:graphql-jit }.......................: avg=308.37µs min=206.49µs med=270.79µs max=29.29ms  p(90)=322.69µs p(95)=357.09µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=703.3µs  min=556.59µs med=640.49µs max=18.87ms  p(90)=739.78µs p(95)=812.78µs
     ✓ { mode:graphql-response-cache }............: avg=368.56µs min=252.69µs med=333.29µs max=18.33ms  p(90)=388.29µs p(95)=419.49µs
     ✓ { mode:graphql }...........................: avg=443.61µs min=317.09µs med=383.29µs max=28.97ms  p(90)=464.69µs p(95)=538.51µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 181240
     http_req_receiving...........................: avg=26.03µs  min=13.8µs   med=22.2µs   max=5.4ms    p(90)=35.1µs   p(95)=38.49µs 
     http_req_sending.............................: avg=10.45µs  min=5.3µs    med=6.79µs   max=5.04ms   p(90)=12µs     p(95)=14.6µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=391.25µs min=183.59µs med=313.99µs max=29.22ms  p(90)=612.29µs p(95)=654.69µs
     http_reqs....................................: 181240  1510.300835/s
     iteration_duration...........................: avg=657.01µs min=395.39µs med=574.59µs max=29.58ms  p(90)=862.89µs p(95)=945.78µs
     iterations...................................: 181240  1510.300835/s
     vus..........................................: 1       min=1         max=2   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://0efa73ea.graphql-yoga.pages.dev

@ardatan ardatan merged commit 2d0cd18 into main Sep 28, 2023
@ardatan ardatan deleted the feat/jwt/allow-token-promise branch September 28, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT Plugin should await the getToken function
2 participants