Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable ci workflow #394

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Reenable ci workflow #394

merged 3 commits into from
Jan 9, 2025

Conversation

Skenvy
Copy link
Contributor

@Skenvy Skenvy commented Jan 9, 2025

Description

Fixes #393

Update ruby version + bundler version

Ran docker run --entrypoint "/bin/bash" --rm -it ghcr.io/actions/jekyll-build-pages:v1.0.13 (currently latest) and got bundle --version of 2.5.11 and ruby --version of 3.3.4

Both versions needed to be upgraded as ruby 3.3 defaulted to bundler 2.1.2 which had ~11k lines of errors/warnings when running the bundle exec jekyll build.

permissions: {}

Workflow sends the token to a 3rd-party (not actions/...-owned) action, so explicitly set the permissions to none.

Refresh Gemfile.lock

Some of the previous gems in the lockfile weren't happy / had errors themselves when running jekyll, so refreshed the lockfile.

Caution

The failure in the workflow is due to it working again but the checker action is finding a problem url on one of the pages, not introduced by this.

Warning

Locally, rebuilt Gemfile.lock with ruby 3.3.6 because it was the only binary ruby for my platform, which came with bundler 2.5.22, so the Gemfile.lock has a BUNDLED WITH version that surpasses the version of the latest image used in the default gh-pages build that was used to set the bundler version in this's ci workflow. But the workflow ran fine with it (despite encountering an intentional error on the html check finding a problem url on the utilities page).

Tip

If at some point a recipe / script for renewing the lockfile that itself is version locked to some specific bundler version, the ruby/setup-ruby action's bundler argument could be changed to "Gemfile.lock"

Copyright Assignment

  • This document is covered by the MIT License, and I agree to contribute this PR under the terms of the license.

Copy link
Member

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unixorn unixorn merged commit 8eba7bf into dotfiles:master Jan 9, 2025
1 check failed
@Skenvy Skenvy deleted the Skenvy-patch-1 branch January 10, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI workflow a lil out of date.
2 participants