Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #393
Update ruby version + bundler version
Ran
docker run --entrypoint "/bin/bash" --rm -it ghcr.io/actions/jekyll-build-pages:v1.0.13
(currently latest) and gotbundle --version
of2.5.11
andruby --version
of3.3.4
Both versions needed to be upgraded as ruby
3.3
defaulted to bundler2.1.2
which had ~11k lines of errors/warnings when running thebundle exec jekyll build
.permissions: {}
Workflow sends the token to a 3rd-party (not
actions/...
-owned) action, so explicitly set the permissions to none.Refresh
Gemfile.lock
Some of the previous gems in the lockfile weren't happy / had errors themselves when running jekyll, so refreshed the lockfile.
Caution
The failure in the workflow is due to it working again but the checker action is finding a problem url on one of the pages, not introduced by this.
Warning
Locally, rebuilt Gemfile.lock with ruby 3.3.6 because it was the only binary ruby for my platform, which came with bundler 2.5.22, so the Gemfile.lock has a
BUNDLED WITH
version that surpasses the version of the latest image used in the default gh-pages build that was used to set the bundler version in this's ci workflow. But the workflow ran fine with it (despite encountering an intentional error on the html check finding a problem url on the utilities page).Tip
If at some point a recipe / script for renewing the lockfile that itself is version locked to some specific bundler version, the
ruby/setup-ruby
action'sbundler
argument could be changed to"Gemfile.lock"
Copyright Assignment