Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the new ITagHelperComponent in ASP.NET Core 2.0 #4033

Closed
scottaddie opened this issue Aug 18, 2017 · 10 comments
Closed

Document the new ITagHelperComponent in ASP.NET Core 2.0 #4033

scottaddie opened this issue Aug 18, 2017 · 10 comments
Assignees
@scottaddie
Labels
Pri1

Comments

@scottaddie
Copy link
Member

scottaddie commented Aug 18, 2017 •
edited by guardrex
Loading

Work with Jass Bagga to get this new 2.0 scenario documented. See aspnet/Mvc#6282 for more info.

I propose the following outline for a new reference doc called Creating Custom Tag Helper Components:

  • Overview
  • Use Cases
  • Adding via Dependency Injection
  • Adding via Controllers
  • Adding via Views

This new doc will be found within the MVC --> Views --> Tag helpers TOC node, and a sample app similar to https://github.com/jbagga/VSLiveDemo/tree/master/src/TagHelperComponentSample will accompany it.
@scottaddie scottaddie self-assigned this Aug 18, 2017
@Rick-Anderson Rick-Anderson added this to the Backlog milestone Aug 23, 2017
@scottaddie
Copy link
Member Author

@danroth27 @jbagga @NTaylorMullen Looking for your feedback on the doc title and outline provided above.

@Rick-Anderson Rick-Anderson added Pri1 and removed Pri2 labels Aug 24, 2017
@jbagga
Copy link
Contributor

jbagga commented Aug 25, 2017 •
edited
Loading

Title recommendation: Modifying <head> or <body> HTML tags with TagHelperComponents (or something similar)
If there is a subsection, explaining how to modify/target other HTML tags by writing your own TagHelperComponentTagHelper implementation, then that can be titled:
Modifying other HTML tags

cc @NTaylorMullen

@NTaylorMullen
Copy link
Contributor

I'd probably have a specific section labeled: Including JavaScript and CSS in your views using TagHelperComponents.

This will be the typical use-case from users. Having other pieces that go into detail on the components would also be required.

@mguinness
Copy link

@NTaylorMullen Are TagHelper components usable from within partial views as well? If so, that would be a good example to include. As sections don't work in partial views, this would be a useful alternative that is often requested.

@NTaylorMullen
Copy link
Contributor

@NTaylorMullen Are TagHelper components usable from within partial views as well?

They are 😄

As sections don't work in partial views, this would be a useful alternative

It wouldn't be super straight forward to use TagHelperComponent's in partials (since they apply to every view) but it's definitely doable. I'm not sure if it's worth noting in the doc due to its complexity.

@mguinness
Copy link

Thanks! I'm sure they'll be used in partial views for things like widgets even if it's a bit of work, but since it's an edge case it makes sense to omit from doc.

@Rick-Anderson Rick-Anderson mentioned this issue Sep 25, 2017
Closed
14 tasks
@guardrex guardrex mentioned this issue Oct 13, 2017
Closed
@Rick-Anderson
Copy link
Contributor

@NTaylorMullen if you can write a sample app for this I'll get the doc scheduled in the next sprint.

@jbagga
Copy link
Contributor

jbagga commented Nov 21, 2017

@Rick-Anderson I have a basic sample here which I can clean up

@jbagga
Copy link
Contributor

jbagga commented Nov 29, 2017 •
edited
Loading

Here is the cleaned up sample https://github.com/jbagga/TagHelperComponentSample. Feel free to modify to create a more realistic example.

Let me know if I can clarify anything or look at the doc.

@scottaddie scottaddie modified the milestones: Sprint 128 (12/02/17 - 12/22/17), Sprint 130 (ends 1/26/2018) Jan 4, 2018
@scottaddie scottaddie mentioned this issue Feb 13, 2018
Closed
@Rick-Anderson Rick-Anderson removed their assignment Mar 9, 2018
@guardrex
Copy link
Collaborator

Cross-ref @DamianEdwards presenting: https://youtu.be/Blo--Qio84w?t=56m51s

@guardrex guardrex mentioned this issue Mar 25, 2018
Closed
10 tasks
@guardrex guardrex changed the title Document the new ITagHelperComponent feature in ASP.NET Core 2.0 Document the new ITagHelperComponent in ASP.NET Core 2.0 Apr 19, 2018
@Rick-Anderson Rick-Anderson mentioned this issue May 17, 2018
Closed
@guardrex guardrex removed their assignment May 18, 2018
@Rick-Anderson Rick-Anderson mentioned this issue Aug 10, 2018
Merged
@scottaddie scottaddie modified the milestones: Sprint 140 (8/13 to 8/31), Sprint 141 (9/3 to 9/21) Sep 6, 2018
scottaddie pushed a commit that referenced this issue Sep 18, 2018
@Rick-Anderson @scottaddie
Add Tag Helper Components doc (#7922)
65eaf9d 
Addresses #4033 
Addresses #5475

[Internal Review Page](https://review.docs.microsoft.com/en-us/aspnet/core/mvc/views/tag-helpers/th-components?view=aspnetcore-2.1&branch=pr-en-us-7922)
@scottaddie scottaddie mentioned this issue Sep 18, 2018
Merged
scottaddie added a commit that referenced this issue Sep 18, 2018
@scottaddie
Add Tag Helper Components doc to ToC (#8598)
388cfb4 
Fixes #4033 
Fixes #5475
Fixes #5476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottaddie scottaddie

Labels
Pri1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@guardrex @rachelappel @NTaylorMullen @Rick-Anderson @jbagga @scottaddie @mguinness