-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling #1146
Error Handling #1146
Conversation
@danroth27 someone going to review? |
.. include:: /../common/stub-topic.txt | ||
Error Handling | ||
============== | ||
By `Steve Smith`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add newline above to separate the title form the authors
Remove all tabs and replace with two spaces. |
.. image:: error-handling/_static/developer-exception-page.png | ||
|
||
The next tab shows the contents of the Querystring collection, if any: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the contents of the Querystring collection
the query string parameters
@Tratcher Please review |
|
||
|stub-icon| Error Handling | ||
========================== | ||
When errors occur in your ASP.NET app, you can handle them in a variety of ways, as described in this article. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be really clear when we're dealing with Exceptions vs status codes. Avoid the word Error from here down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed most to Exception, except in a few places where I thought Error still appropriate.
@Tratcher so... ship it... ? |
There's a few more comments unaddressed, or at least you didn't push the changes. |
Yeah, sorry, apparently one push failed. Also, removed the unnecessary MapWhen. |
|
511bffc
to
37e3b08
Compare
Fixes #124
@Rick-Anderson @danroth27