Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling #1146

Merged
merged 1 commit into from
May 1, 2016
Merged

Error Handling #1146

merged 1 commit into from
May 1, 2016

Conversation

ardalis
Copy link
Contributor

@ardalis ardalis commented Apr 11, 2016

@ardalis
Copy link
Contributor Author

ardalis commented Apr 26, 2016

@danroth27 someone going to review?

.. include:: /../common/stub-topic.txt
Error Handling
==============
By `Steve Smith`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline above to separate the title form the authors

@danroth27
Copy link
Member

Remove all tabs and replace with two spaces.

.. image:: error-handling/_static/developer-exception-page.png

The next tab shows the contents of the Querystring collection, if any:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the contents of the Querystring collection

the query string parameters

@danroth27
Copy link
Member

@Tratcher Please review


|stub-icon| Error Handling
==========================
When errors occur in your ASP.NET app, you can handle them in a variety of ways, as described in this article.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be really clear when we're dealing with Exceptions vs status codes. Avoid the word Error from here down.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed most to Exception, except in a few places where I thought Error still appropriate.

@ardalis
Copy link
Contributor Author

ardalis commented Apr 30, 2016

@Tratcher so... ship it... ?

@Tratcher
Copy link
Member

There's a few more comments unaddressed, or at least you didn't push the changes.

@ardalis
Copy link
Contributor Author

ardalis commented Apr 30, 2016

Yeah, sorry, apparently one push failed. Also, removed the unnecessary MapWhen.

@Tratcher
Copy link
Member

:shipit:

@ardalis ardalis force-pushed the ardalis/error-handling branch from 511bffc to 37e3b08 Compare May 1, 2016 17:29
@ardalis ardalis merged commit 37e3b08 into master May 1, 2016
@ardalis ardalis deleted the ardalis/error-handling branch June 7, 2016 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants