Fix getting started app #3079
Merged
Fix getting started app #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the database with EnsureCreated instead of with Migrations. Fixes #3078
ajcvickers
suggested changes
Feb 4, 2021
This reverts commit b4e1cdf.
| @@ -9,7 +9,7 @@ public class BloggingContext : DbContext | |||
| public DbSet<Post> Posts { get; set; } | |||
|
|
|||
| protected override void OnConfiguring(DbContextOptionsBuilder options) | |||
| => options.UseSqlite("Data Source=blogging.db"); | |||
| => options.UseSqlite(@"Data Source=C:\blogging.db"); | |||
There was a problem hiding this comment.
The VS Mac tab is available but probably not what you want. Need either code comments or note before code for mac/linix
There was a problem hiding this comment.
Can also add a comment here in code what to use if your are using mac/linux.
There was a problem hiding this comment.
I agree, it turns out even folks reading localized content prefer helpful english code comments. I hate the chrome of a note. I'd move this to the code comments and remove the note. Note chrome detracts from the flow of the article.
There was a problem hiding this comment.
Changed to note into a code comment
Rick-Anderson
approved these changes
Feb 16, 2021
ajcvickers
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3078