Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom WebSocket parameters #497

Merged
merged 4 commits into from
Dec 14, 2018

Conversation

cquesnel
Copy link
Contributor

Allows users to pass custom WebSocket parameters allowing to pass request headers and cookies.

Fixes #495 and #496

@cquesnel
Copy link
Contributor Author

@chkr1011 The build won't pass because of an expired certificate in appveyor

@chkr1011
Copy link
Collaborator

Thank you for your contribution 👍
Good work! But I have some things to change:

  • Please use a default parameter instead of an overload. This is used for all other methods as well. So using a overload will break this pattern.
  • I am not sure but is the Cookie container also available for UWP? Did you build for all supported platforms?

Best regards
Christian

@cquesnel
Copy link
Contributor Author

@chkr1011

  • I changed the method to use a default parameter
  • For the cookie container, I simply exposed a field that was already present, so I'm pretty sure it's compatible. I did build the whole solution so there shouldn't be any problems there.

@chkr1011 chkr1011 merged commit ba4fdfb into dotnet:develop Dec 14, 2018
@cquesnel cquesnel deleted the feature/add-websocket-parameters branch December 14, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants