-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed first two bytes of the git commit ID, encoded as an integer in AssemblyInformationalVersion #207
Labels
Comments
It's on by default. What are you seeing instead? |
version.json {
"$schema": "https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "1.2",
"assemblyVersion": {
"precision": "revision"
}
} Output //------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.42000
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generated>
//------------------------------------------------------------------------------
[assembly: System.Reflection.AssemblyVersionAttribute("1.2.1.26893")]
[assembly: System.Reflection.AssemblyFileVersionAttribute("1.2.1.26893")]
[assembly: System.Reflection.AssemblyInformationalVersionAttribute("1.2.1+g0d690a243b")]
internal sealed partial class ThisAssembly {
internal const string AssemblyVersion = "1.2.1.26893";
internal const string AssemblyFileVersion = "1.2.1.26893";
internal const string AssemblyInformationalVersion = "1.2.1+g0d690a243b";
internal const string AssemblyName = "redacted";
internal const string AssemblyTitle = "redacted";
internal const string AssemblyConfiguration = "Debug";
internal const string RootNamespace = "redacted";
private ThisAssembly() {
}
} |
I see. The docs are wrong/outdated. NB.GV never puts the 4th integer into the AssemblyInformationalVersion: Adding the first two bytes of the commit ID as an integer in the AssemblyInformationalVersion would be redundant because the git commit ID itself can be and is present in that same field. Closed by c518c03 |
AArnott
pushed a commit
that referenced
this issue
Sep 14, 2023
Bumps [StyleCop.Analyzers.Unstable](https://github.com/DotNetAnalyzers/StyleCopAnalyzers) from 1.2.0.435 to 1.2.0.507. - [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases) - [Changelog](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/KnownChanges.md) - [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/commits) --- updated-dependencies: - dependency-name: StyleCop.Analyzers.Unstable dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The sample output should in the .NET support documentation has the first two bytes of the git comment ID, encoded as an integer in the AssemblyInformationVersion (pasted below). How do I configure my version.json to get a similar output?
The text was updated successfully, but these errors were encountered: