Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integration with VS2017 SDK builds #93

Closed
AArnott opened this issue Dec 17, 2016 · 3 comments
Closed

Better integration with VS2017 SDK builds #93

AArnott opened this issue Dec 17, 2016 · 3 comments
Assignees
@AArnott
Labels
enhancement

Comments

@AArnott
Copy link
Collaborator

AArnott commented Dec 17, 2016

This issue tracks the work (in and out of this project) to get Nerdbank.GitVersioning to integrate well with the new project type introduced by the .NET Core project templates in Visual Studio 2017.
@AArnott AArnott self-assigned this Dec 17, 2016
@AArnott
Copy link
Collaborator Author

AArnott commented Dec 17, 2016 •
edited
Loading

Starting with 1.5.61 Nerdbank.GitVersioning can successfully perform its functions on the SDK builds of .NET assemblies.

However, the new /t:Pack target of these projects do not import any referenced NuGet packages' MSBuild files. So we can't yet set the version of the NuGet packages built with the Pack target.

@clairernovotny
Copy link
Contributor

Part of this should include creating netcoreapp1.0/netstandard version of the task using the coreclr msbuild targets so that it can work with dotnet build and not just msbuild.

@AArnott
Copy link
Collaborator Author

AArnott commented Dec 22, 2016

The package version is fixed by 584f789.

@onovotny: #56 already tracks .NET Core support.

@AArnott AArnott closed this as completed Dec 22, 2016
@AArnott AArnott mentioned this issue Jan 21, 2017
Closed
19 tasks
AArnott added a commit that referenced this issue Sep 5, 2022
@AArnott
Merge pull request #93 from AArnott/embedPDBs
2ebe738 
Embed PDBs for all local builds

This ensures that if you build a dll and copy it somewhere, then build again, you haven't lost the ability to debug the original dll because it carries the pdb with it wherever it goes.
We do not embed the pdb in the official builds however because the official builds will archive the pdb so it isn't lost, and it would unnecessarily bloat the assembly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AArnott @clairernovotny